Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 182737
| Summary: | Review Request: kdetoys | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gauret |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-03-09 02:14:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Rex Dieter
2006-02-24 13:07:46 UTC
Needs work:
* BuildRequires: gettext is missing (required by the %find_lang macro)
* The package should contain the text of the license
(wiki: Packaging/ReviewGuidelines)
* The package contains libtool archive files (*.la)
(wiki: PackagingGuidelines#StaticLibraries)
They can be required by KDE apps sometimes. If it's the case here, it would be
good to add a comment about it.
* Desktop files: some don't contain the "Application" category, and the "vendor"
should be fedora. (wiki: PackagingGuidelines#desktop)
Notes:
* maybe "%{!?debug_package:-strip}" can be dropped in make install ? What do you
think (IIRC it's needed for old distributions only)
> * BuildRequires: gettext is missing (required by the %find_lang macro) Really? Didn't know that, thanks. > * The package should contain the text of the license Duh, can't believe I missed that. > * The package contains libtool archive files (*.la) These are for loadable modules, not shared libraries. Regardless, in this case, they're needed. > * Desktop files: some don't contain the "Application" category, > and the "vendor" should be fedora. (wiki: PackagingGuidelines#desktop) Category: OK. vendor, I recently raised that issue on the packagers mailing list and the consensus was to only use fedora as vendor in the absense of an existing/proper one (in this case, the proper vendor is kde). > * maybe "%{!?debug_package:-strip}" can be dropped Yeah, probably. That's just to help folks who don't have redhat-rpm-config installed. %changelog
* Mon Mar 06 2006 Rex Dieter <rexdieter[AT]users.sf.net> 7:3.3.5-3
- %%doc AUTHORS COPYING README
- BR: gettext
- drop %%{?debug_package} reference
- desktop-file-install --vendor="kde"/--add-category="Application",
where needed
- comment inclusion of .la files
Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kdetoys-3.5.1-3.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kdetoys-3.5.1-3.src.rpm
Review for release 3: * RPM name is OK * Source kdetoys-3.5.1.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine APPROVED Thanks, importing now. 6100 (kdetoys): Build on target fedora-development-extras succeeded.
Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-development-extras/6100-kdetoys-3.5.1-3.fc5/
Yay.
|