Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1830957

Summary: python-rasterio fails to build with click 7.1
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-rasterioAssignee: Elliott Sales de Andrade <quantum.analyst>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, mhroncok, mplch, python-sig, quantum.analyst
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-rasterio-1.1.5-1.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-07 06:26:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1803234, 1785415, 1811727    

Description Miro Hrončok 2020-05-04 12:17:24 UTC
python-rasterio fails to build with click 7.1 on Python 3.8 and Python 3.9.0a6.

______________________ test_rasterize_invalid_like_raster ______________________
tmpdir = local('/tmp/pytest-of-mockbuild/pytest-0/test_rasterize_invalid_like_ra0')
runner = <click.testing.CliRunner object at 0xffff7d5f25b0>
basic_feature = {'geometry': {'coordinates': [[(2, 2), (2, 4.25), (4.25, 4.25), (4.25, 2), (2, 2)]], 'type': 'Polygon'}, 'properties': {'val': 15}, 'type': 'Feature'}
    def test_rasterize_invalid_like_raster(tmpdir, runner, basic_feature):
        output = str(tmpdir.join('test.tif'))
        result = runner.invoke(
            main_group,
            ['rasterize', output, '--like', str(tmpdir.join('foo.tif'))],
            input=json.dumps(basic_feature))
    
        assert result.exit_code == 2
>       assert 'Invalid value for "--like":' in result.output
E       assert 'Invalid value for "--like":' in "Usage: main-group rasterize [OPTIONS] INPUTS... OUTPUT\nTry 'main-group rasterize --help' for help.\n\nError: Invalid value for '--like': Path '/tmp/pytest-of-mockbuild/pytest-0/test_rasterize_invalid_like_ra0/foo.tif' does not exist.\n"
E        +  where "Usage: main-group rasterize [OPTIONS] INPUTS... OUTPUT\nTry 'main-group rasterize --help' for help.\n\nError: Invalid value for '--like': Path '/tmp/pytest-of-mockbuild/pytest-0/test_rasterize_invalid_like_ra0/foo.tif' does not exist.\n" = <Result SystemExit(2)>.output
tests/test_rio_rasterize.py:218: AssertionError

Seems like the quotation marks were changed.

See https://koschei.fedoraproject.org/package/python-rasterio?last_seen_ts=1587526323&collection=f33


For the build logs with Python 3.9, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01365582-python-rasterio/

For all our attempts to build python-rasterio with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-rasterio/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Elliott Sales de Andrade 2020-05-05 05:54:40 UTC
Can pull this patch https://github.com/mapbox/rasterio/commit/9cb86d796cf80f2327ac7524bd88ee3abb1d6459 from upstream if this is urgent.

Comment 2 Miro Hrončok 2020-05-05 08:33:18 UTC
Not urgent yet. We plan to proceed in side tag in ~2 weeks.

Comment 3 Miro Hrončok 2020-05-25 13:02:36 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 4 Miro Hrončok 2020-05-29 07:12:16 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.