Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at

Bug 183291

Summary: Review Request: ipod-sharp
Product: [Fedora] Fedora Reporter: Christopher Aillon <caillon>
Component: Package ReviewAssignee: Brian Pepple <bdpepple>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-03-10 19:57:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 183290    
Bug Blocks: 163779, 183292    

Description Christopher Aillon 2006-02-27 23:03:52 UTC
Spec and SRPM from:
Description: ipod-sharp provides high-level feature support for Apple's iPod and binds libipoddevice. ipod-sharp is written in C# under Mono.

Comment 1 Brian Pepple 2006-03-02 15:31:02 UTC
734956f3505f776c6920d4ae687f4bee  ipod-sharp-0.5.15.tar.gz

* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Builds fine in Mock (once missing BR (hal-devel) added to spec)
* Package installs and uninstalls cleanly on FC5.
* Make succeeds even when %{_smp_mflags} is defined

* Missing Build Requirement for hal-devel
* Source URL isn't canonical. Should be{name}/%{name}-%{version}.tar.gz
* License is LGPL, not GPL.
* Add COPYING file to package.
* rpmlint gives the following errors:
  E: ipod-sharp no-binary
  E: ipod-sharp only-non-binary-in-usr-lib
  W: ipod-sharp no-documentation
  W: ipod-sharp devel-file-in-non-devel-package /usr/lib/pkgconfig/ipod-sharp.pc
  W: ipod-sharp devel-file-in-non-devel-package /usr/lib/pkgconfig/ipod-sharp-ui.pc

  Most of these errors can be ignored, or be easily corrected (like adding the
COPYING file).  You should probably add a -devel sub-package to handle the *.pc
files, though.

APPROVED, once these items are corrected.   

Comment 2 Brian Pepple 2006-03-10 19:54:05 UTC
This has been built hasn't it?  If so, this bug can be closed.

Comment 3 Christopher Aillon 2006-03-10 19:57:25 UTC
Yeah, I'm just lazy/forgetful.  ;-)