Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 184210
Summary: | Review Request: nc6 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Radek Vokál <rvokal> |
Component: | Package Review | Assignee: | Michael Fleming <mfleming+rpm> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://people.redhat.com/rvokal/nc6/nc6-1.0-2.src.rpm | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-03-11 10:23:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Radek Vokál
2006-03-07 11:05:10 UTC
I've had a crack at this package myself locally, I'll give it a review and let you know how it goes. Time out... Isn't netcat/nc 1.82fc4.1 in updates-released already IPv6 enabled? It has a -6 option and I've used it against IPv6 services. This appears to be a redundant effort. I was under the impression that the netcat6 stuff had all been merged back into netcat. Is there something that nc6 does that the latest nc is missing? Well, the question is which package is more recent and living. The current netcat packages is port from OpenBSD. Every time they bump a new release I have to rewrite the code a bit 'cos OpenBSD has some additional functionality which linux kernel doesn't have. My intention was to propose nc6 package and maybe in FC6 time switch from OpenBSD nc to nc6. Also I've ported some functions from nc6 to nc, but I can't honestly say which package is better. NEEDSWORK Review for release 1: * RPM name is OK * Source nc6-1.0.tar.bz2 is the same as upstream * This is the latest version * Builds fine in mock * Runs OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * The BuildRoot must be cleaned at the beginning of %install * rpmlint of nc6: Nonstandard group (Try Applications/Internet or Applications/System?) Ok, changes done. nc6 is in group Applications/Internet now. http://people.redhat.com/rvokal/nc6/nc6-1.0-2.src.rpm Reviewed the new SRPM - looks much better, all reported issues fixed. APPROVED. Tip: toss a %{?dist} tag in Release to make upgrades between Core releases a little easier for users and packagers alike. See http://www.fedoraproject.org/wiki/DistTag. Certainly not a big issue, but it's very convenient. :-) |