Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 184305
Summary: | Review Request: ftnchek - Static analyzer for Fortran 77 programs | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | pertusus |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.cora.nwra.com/~orion/fedora/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-03-08 23:22:24 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Orion Poplawski
2006-03-07 22:06:26 UTC
1. The RPM CFLAGS are not set. Here is a sed one-liner that solves that. You may prefer a patch, do what you prefer: sed -i -e 's/CFLAGS="-DUNIX.*"//' configure 2. you don't install the emacs stuff. Not a big deal. If you want to package it, you may want to have them in a subpackage ftncheck-emacs. Here is how I do to have the emacs files in the buildroot: mkdir -p $RPM_BUILD_ROOT%{_datadir}/emacs/site-lisp %makeinstall datadir=$RPM_BUILD_ROOT%{_datadir}/ftnchek \ lispdir=$RPM_BUILD_ROOT%{_datadir}/emacs/site-lisp 3. I prefer something like %{_mandir}/man1/dcl2inc.1* instead of %{_mandir}/man1/dcl2inc.1.gz such that it works if man pages are no gzipped, or are bzip2ed and so on. It is my personal taste 4. you should add FAQ and PATCHES in %doc Please fix 1. and 4., and do whatever you like with 2. and 3. Thanks for the review! (In reply to comment #1) > 1. The RPM CFLAGS are not set. Here is a sed one-liner that solves that. You may > prefer a patch, do what you prefer: > > sed -i -e 's/CFLAGS="-DUNIX.*"//' configure > I also did: export CFLAGS="$RPM_OPT_FLAGS -DUNIX" as it appears that the UNIX flag is still required. > 2. you don't install the emacs stuff. Not a big deal. If you want to package it, > you may want to have them in a subpackage ftncheck-emacs. Here is how I do to > have the emacs files in the buildroot: > > mkdir -p $RPM_BUILD_ROOT%{_datadir}/emacs/site-lisp > %makeinstall datadir=$RPM_BUILD_ROOT%{_datadir}/ftnchek \ > lispdir=$RPM_BUILD_ROOT%{_datadir}/emacs/site-lisp Made an emacs sub-package. I also added a BR on emacs so the .elc file would be built. > 3. I prefer something like > %{_mandir}/man1/dcl2inc.1* > instead of > %{_mandir}/man1/dcl2inc.1.gz > such that it works if man pages are no gzipped, or are bzip2ed and so on. It is > my personal taste Good idea > 4. you should add FAQ and PATCHES in %doc done. New version: http://www.cora.nwra.com/~orion/fedora/ftnchek.spec http://www.cora.nwra.com/~orion/fedora/ftnchek-3.3.1-2.src.rpm - one rpmlint warning that could be ignored W: ftnchek-emacs no-documentation - named according to the guidelines - open-source MIT licence, included - follow packaging guidelines - match upstream source - builds in fc5 mock Needswork + should own %{_datadir}/ftnchek/ Nitpick - It would be more consistent to have a dot (.) at the end of the description for the emacs subpackage. That could be fixed later, though. (In reply to comment #3) > - one rpmlint warning that could be ignored > > W: ftnchek-emacs no-documentation > Ignored. > + should own %{_datadir}/ftnchek/ Oops, fixed. > Nitpick > > - It would be more consistent to have a dot (.) at the end of the description > for the emacs subpackage. That could be fixed later, though. Fixed. New version: http://www.cora.nwra.com/~orion/fedora/ftnchek.spec http://www.cora.nwra.com/~orion/fedora/ftnchek-3.3.1-3.src.rpm Everything is in order, so APPROVED Checked in. Added to owners.list Built on devel. |