Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 184467
| Summary: | Review Request: cmake - Cross-platform make system | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Gérard Milmeister <gemi> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gemi, rdieter |
| Target Milestone: | --- | Flags: | orion:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.cora.nwra.com/~orion/fedora/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-03-29 20:37:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Orion Poplawski
2006-03-08 23:20:39 UTC
- rpmlint complains about development. Since they are part of the main package, these errors can be ignored. - Maybe also include the Example directory with the doc dir. - Include the cmake-mode.el for emacs, the .vim files for vim http://www.cora.nwra.com/~orion/fedora/cmake-2.2.3-2.src.rpm http://www.cora.nwra.com/~orion/fedora/cmake.spec - Made emacs and vim sub-packages for the .el and .vim files. Haven't tested them yet though. - Include Examples in the docs - "cp -a Docs/Example ..." should be "cp -a Example ..." - instead of requiring /usr/share/emacs/site-lisp: Requires: emacs-common The same goes for vim: Requires: vim-common The problem is, that the location is only correct for a specific version of vim. Is there no version-independent site directory like for emacs? (In reply to comment #3) > - "cp -a Docs/Example ..." should be "cp -a Example ..." Fixed. > - instead of requiring /usr/share/emacs/site-lisp: > Requires: emacs-common > The same goes for vim: > Requires: vim-common > The problem is, that the location is only correct for > a specific version of vim. Is there no version-independent > site directory like for emacs? > I prefer the way it is. What the package really requires is the existence of the directories /usr/share/emacs/site-lisp. If this directory ends up being in another package, I don't have to do anything. I was not able to find a version-independent site directory for vim, unfortunately. Re: emacs site-lisp Another simplistic approach (that some, me not included, object to) is to 1. install the files to /usr/share/emacs/site-lisp 2. include these in the main pkg (ie, no subpkg) 3. Add no additional/special Requires wrt emacs. It's simple and it works (when emacs is installed, or any other package that "owns" /usr/share/emacs/site-lisp). At worst, when emacs is not installed, you have files installed into an unowned dir. IMO, the benefits of this approach (mostly it's simplicity) outweigh the disadvantage of installing files into a potentially unowned dir (site-lisp). The same general approach can be applied to the vim files too. In general I object to potentially unknowned directories :-) However in this case, for simplicity's sake I agree. Another possibility is to own "/usr/share/emacs". Several other packages do this. http://www.cora.nwra.com/~orion/fedora/cmake-2.2.3-3.src.rpm http://www.cora.nwra.com/~orion/fedora/cmake.spec How about this? It owns the emacs and vim directories so they are created with proper permissions, but doesn't an any runtime requirements. Looks good now. APPROVED checked in, built on devel, added to owners.list. Package Change Request ====================== Package Name: cmake New Branches: EL-4 EL-5 Package Change Request ====================== Package Name: cmake New Branches: F-9 cvs done. |