Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 185221
Summary: | Review Request: wifiroamd | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | jafo-redhat | ||||
Component: | Package Review | Assignee: | Ed Hill <ed> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | ||||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-04-21 18:37:13 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
jafo-redhat
2006-03-12 04:16:59 UTC
Created attachment 126003 [details]
quick fix for restart problem
Without the above patch, wifiroamd would not reliably restart per the
following error messages. I'm not 100% certain whether this is the best
way to fix the problem but it does work for me -- no more "existing
process" errors.
[XXX ~]: /etc/init.d/wifiroamd restart
Stopping wifiroamd: [ OK ]
Starting wifiroamd: Another process, id=32189, already exists. Aborting.
[ OK ]
[XXX ~]: /etc/init.d/wifiroamd restart
Stopping wifiroamd: [FAILED]
Starting wifiroamd: [ OK ]
Hi Jafo, heres a quick review: good: + naming OK + license (GPL) is OK + builds in mock on FC4 + rpmlint reports: W: wifiroamd conffile-without-noreplace-flag /etc/wifiroamd/config-defaults which is probably safe to ignore + source matches upstream + no unnecessary BuildRequires + spec file is clean, legible, and has consistent macros + code not content OK + no shared libs or need for -devel + runs and works nicely on my FC4 laptop with NetworkManager shut off (which is currently the default for NM) nits: - please include the file "debian/copyright" in %doc - BuildRoot should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - please add /var/lib/wifiroamd to the list of owned dirs - I think the scriptlets should have if-s around them such as: %post if [ $1 -eq 1 ]; then chkconfig --add wifiroamd fi %preun if [ $1 -eq 0 ]; then chkconfig --del wifiroamd fi but please correct me if thats wrong! Also, I'm wondering if there will or could be some conflicts with NetworkManager and, if so, how they should be handled. Currently, NM is off by default and so is wifiroamd so they can only (potentially ??) conflict if a user chooses to turn on both simultaneously. And even with both on, I'm not certain what problems, if any, would be observed. Perhaps someone who knows a bit more about NetworkManager can step forward and say something here? I have released a 1.04 version which adds the patch and makes the changes suggested by Ed, except for the BuildRoot which as far as I could tell was exactly as it already is. Thanks for the feedback, Ed. Sean Hi Jafo, the 1.04 version looks good. Theres a very minor nit wrt the BuildRoot -- yours has expanded the %{version} macro relative to the standard one: %{_tmppath}/%{name}-1.04-%{release}-root-%(%{__id_u} -n) %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) but its not a big deal--please feel free to change it in CVS after checkin. APPROVED. I'll be happy to sponsor you per the process outlined at: http://fedoraproject.org/wiki/Extras/Contributors and please let me know if you have questions/problems/whatever. Ok, I get it now. My release script replaced %{version} in the spec file with the actual version, for handling the Version: line. I've changed the way this is done, and released version 1.05 with that change in it. Just for reference, I've talked to the submitter (who is also the upstream developer) and have agreed to maintain this package in Extras. It built cleanly on FC-4,5 and devel. |