Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1852437

Summary:	perl-Perl-Critic-1.138-4.fc33 FTBFS with Perl 5.32: subroutine name is a homonym for builtin function isa at line 140
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	perl-Perl-Critic	Assignee:	Paul Howarth <paul>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jose.p.oliveira.oss, paul, perl-devel, rob.myers
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	perl-Perl-Critic-1.138-5.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-11 17:54:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1803234

Description Petr Pisar 2020-06-30 12:28:13 UTC

perl-Perl-Critic-1.138-4.fc33 fails to build in Fedora 33 because a test fails with Perl 5.32:

t/gh-734.t .................................... ok
#   Failed test 'Test::Perl::Critic for "blib/lib/Perl/Critic/Document.pm"'
#   at /usr/share/perl5/vendor_perl/Test/Perl/Critic.pm line 121.
# 
#   blib/lib/Perl/Critic/Document.pm: Subroutine name is a homonym for builtin function isa at line 140, column 1.  See page 177 of PBP.  (Severity: 4, Subroutines::ProhibitBuiltinHomonyms)
xt/40_criticize-code.t ........................ 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/198 subtests

Comment 1 Paul Howarth 2020-06-30 12:33:17 UTC

As "isa" is a documented part of Perl::Critic::Document's API, I suspect that the fix for this will just be to add a ##nocritic pragma to waive the check.

Comment 2 Paul Howarth 2020-07-11 17:54:10 UTC

I worked around this using a "## nocritic" pragma, but the long-term fix might be to include making "isa" a special case like "import", "AUTOLOAD", and "DESTROY" already are, as they are commonly overridden. That's one for upstream to decide though.