Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 185288
| Summary: | Review Request: libchmxx - C++ bindings for chmlib | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | rdieter |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-24 00:08:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Patrice Dumas
2006-03-13 10:14:07 UTC
2 initial comments: 1. put %doc html/ in the -devel pkg 2. omit static lib Fixed here: http://www.environnement.ens.fr/perso/dumas/fc-srpms/libchmxx-0.1-2.src.rpm I personally think that there are valid uses of an app linked statically with chmlib/chmlibxx (for portability), however as there are no static libs with chmlib, it doesn't make sense to have some with libchmxx. - rpmlint checks return: W: libchmxx-debuginfo objdump-failed E: libchmxx-devel only-non-binary-in-usr-lib symlink, can ignore You need a %defattr on %files devel - package meets naming guidelines - package meets packaging guidelines - license ([L]GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Looking good otherwise. Fixed here (too lazy to bump release) http://www.environnement.ens.fr/perso/dumas/fc-srpms/libchmxx-0.1-2.src.rpm Fixed version builds fine. APPROVED as per comment 3 Built in devel, thanks for the review. |