Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 185370
| Summary: | Review Request: gtklp - A GTK frontend to CUPS | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gérard Milmeister <gemi> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jpmahowald |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-05-16 18:56:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Gérard Milmeister
2006-03-14 00:16:55 UTC
Build failed. /usr/bin/ld: cannot find -lgnutls collect2: ld returned 1 exit status make[2]: *** [gtklp] Error 1 Added buildreq gnutls-devel. Now builds fine. Package at: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/gtklp-1.2.1-2.src.rpm - rpmlint checks return: W: gtklp incoherent-version-in-changelog 1.2.1-1 1.2.1-2 Minor, release just doesn't match E: gtklp incorrect-locale-subdir /usr/share/locale/chs/LC_MESSAGES/gtklp.mo E: gtklp incorrect-locale-cs /usr/share/locale/cz/LC_MESSAGES/gtklp.mo E: gtklp incorrect-locale-subdir /usr/share/locale/cht/LC_MESSAGES/gtklp.mo - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - locales handled properly - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop files It'd be a good idea to inform the author when this goes through so they can add it to their distribution list. APPROVED Couple of quick items: 1. Duplicate BuildRequires: openssl-devel (provided by cups-devel) 2. Requires for cups shouldn't be needed, since the devel packages soname should pull this in. (In reply to comment #3) > E: gtklp incorrect-locale-cs /usr/share/locale/cz/LC_MESSAGES/gtklp.mo This should be in facte cs instead of cz. > E: gtklp incorrect-locale-subdir /usr/share/locale/chs/LC_MESSAGES/gtklp.mo > E: gtklp incorrect-locale-subdir /usr/share/locale/cht/LC_MESSAGES/gtklp.mo These seem to be Chinese locales. I suggest removing these three, and notifying upstream about it. (In reply to comment #4) > Couple of quick items: > > 1. Duplicate BuildRequires: openssl-devel (provided by cups-devel) OK > 2. Requires for cups shouldn't be needed, since the devel packages soname should > pull this in. This only pulls the cups libraries in. However gtklp doesn't make sense without the printing system itself. Is this still APPROVED, and should I go ahead with modifications I suggested? (In reply to comment #6) > Is this still APPROVED, and should I go ahead with modifications > I suggested? Still approved. Go ahead with the locale fix, you can get further review before on it before building if you wish. Built on FC-4, FC-5 and FC-6. Added entry to owners.list. Thanks for the review! |