Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 186002
| Summary: | Review Request: archmage - Extensible reader/decompiler of files in CHM format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
| Component: | Package Review | Assignee: | Shahms E. King <shahms> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-19 21:24:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Patrice Dumas
2006-03-20 21:39:40 UTC
Good: - rpmlint gives no errors - builds in mach just fine - spec file and package name match (but see below) - GPL license, license included, etc. - md5sum matches upstream - it meets the rest of the MUST clauses The only "bad" thing I could find is that I don't think python-archmod is the most appropriate name as the python module itself is secondary to the binary functionality, if I'm not mistaken. It seems similar in this regard to bzr and yum, and should be named appropriately. Other than that, the package looks good. I followed the packaging guidelines blindly... The packaging guidelines are in my opinion quite misleading on that subject. For perl it doesn't matter, as there is CPAN which is the reference for what is a module and what isn't for python there should be a word to help packagers choice. I have uploaded a srpm for archmage here: http://www.environnement.ens.fr/perso/dumas/fc-srpms/archmage-0.0.7-1.src.rpm Should archmage provides: python-archmod, or even conflicts? Yes, the packaging guidelines are unclear on that. It's something that needs to be clarified. I'd leave out the provides. - rpmlint (still) gives no errors and there are no other regressions, the package looks good. ACCEPTED Built for devel, thanks. |