Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1863989

Summary: libdigidocpp: FTBFS in Fedora rawhide/f33
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: libdigidocppAssignee: Dmitri Smirnov <cserpentis>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 33CC: cserpentis, germano.massullo
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libdigidocpp-3.14.3-4.fc33 libdigidocpp-3.14.3-4.fc32 libdigidocpp-3.14.3-4.fc31 libdigidocpp-3.14.3-4.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-02 00:34:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1803234    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2020-08-03 17:46:48 UTC 
libdigidocpp failed to build from source in Fedora rawhide/f33

https://koji.fedoraproject.org/koji/taskinfo?taskID=47992734


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
Please fix libdigidocpp at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
libdigidocpp will be orphaned. Before branching of Fedora 34,
libdigidocpp will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source
Comment 1 Fedora Release Engineering 2020-08-03 17:46:49 UTC 
Created attachment 1705435 [details]
build.log
Comment 2 Fedora Release Engineering 2020-08-03 17:46:51 UTC 
Created attachment 1705436 [details]
root.log

file root.log too big, will only attach last 32768 bytes
Comment 3 Fedora Release Engineering 2020-08-03 17:46:52 UTC 
Created attachment 1705437 [details]
state.log
Comment 4 Ben Cotton 2020-08-11 14:13:49 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.
Comment 5 Germano Massullo 2020-09-26 09:13:55 UTC 
EPEL branch uses the same spec file of master branch.
There, it has recently been introduced the new cmake macros [1]

%cmake OR %cmake_kf5
%cmake_build
%cmake_install

but they do not work on EL8 at the moment, so we need to add proper macros to skip them.
A good example how to handle this, is my spec file
https://src.fedoraproject.org/rpms/darktable/blob/master/f/darktable.spec

[1]: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds
Comment 6 Fedora Update System 2020-09-27 18:44:45 UTC 
FEDORA-2020-ee699f31eb has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ee699f31eb
Comment 7 Fedora Update System 2020-09-28 01:01:57 UTC 
FEDORA-2020-ee699f31eb has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-ee699f31eb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ee699f31eb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Fedora Update System 2020-09-28 01:11:36 UTC 
FEDORA-EPEL-2020-dabfe1da20 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-dabfe1da20

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 9 Fedora Update System 2020-09-28 01:15:21 UTC 
FEDORA-2020-0f3b3c7abb has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-0f3b3c7abb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0f3b3c7abb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 10 Fedora Update System 2020-09-28 01:54:31 UTC 
FEDORA-2020-657683175f has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-657683175f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-657683175f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 11 Germano Massullo 2020-09-28 15:03:42 UTC 
(In reply to Germano Massullo from comment #5)
> EPEL branch uses the same spec file of master branch.
> There, it has recently been introduced the new cmake macros [1]
> 
> %cmake OR %cmake_kf5
> %cmake_build
> %cmake_install
> 
> but they do not work on EL8 at the moment, so we need to add proper macros
> to skip them.
> A good example how to handle this, is my spec file
> https://src.fedoraproject.org/rpms/darktable/blob/master/f/darktable.spec
> 
> [1]: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds


The spec file has been improved by Andreas Schneider, you may want to check it, since I previously made some little mistakes
Comment 12 Dmitri Smirnov 2020-09-30 23:05:48 UTC 
I've updated the build spec file and the package now builds just fine on rawhide and 33, I tested the packages and they were fully functional. Waiting for push to production to close this one.
Comment 13 Fedora Update System 2020-10-02 00:34:24 UTC 
FEDORA-2020-ee699f31eb has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 14 Germano Massullo 2020-10-03 17:57:17 UTC 
(In reply to Germano Massullo from comment #11)
> (In reply to Germano Massullo from comment #5)
> > EPEL branch uses the same spec file of master branch.
> > There, it has recently been introduced the new cmake macros [1]
> > 
> > %cmake OR %cmake_kf5
> > %cmake_build
> > %cmake_install
> > 
> > but they do not work on EL8 at the moment, so we need to add proper macros
> > to skip them.
> > A good example how to handle this, is my spec file
> > https://src.fedoraproject.org/rpms/darktable/blob/master/f/darktable.spec
> > 
> > [1]: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds
> 
> 
> The spec file has been improved by Andreas Schneider, you may want to check
> it, since I previously made some little mistakes

I definitely fixed a lot of problems in the spec file. If you get errors while building libdigidocpp in other branches, you really may want to check again at the darktable spec file
Comment 15 Fedora Update System 2020-10-05 17:32:25 UTC 
FEDORA-2020-0f3b3c7abb has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 16 Fedora Update System 2020-10-05 18:35:03 UTC 
FEDORA-2020-657683175f has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 17 Fedora Update System 2020-10-12 14:57:39 UTC 
FEDORA-EPEL-2020-dabfe1da20 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.