Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1867440
| Summary: | new version of rpkg makes fedpkg fail with python issue: join() argument must be str, bytes... | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | laolux |
| Component: | rpkg | Assignee: | Ondřej Nosek <onosek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 32 | CC: | cqi, dennis, jkeating, lsedlar, onosek, s |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rpkg-1.60-8.fc31 rpkg-1.61-1.fc32 rpkg-1.61-1.el7 rpkg-1.61-1.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-09-09 14:17:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
laolux
2020-08-10 02:39:22 UTC
Ok, it seems like some people have problems reproducing the issue, so I made an example in a podman container and can reliably reproduce the issue. steps to reproduce: fresh fedora 32 container: $ podman run -it registry.fedoraproject.org/fedora:32-x86_64 # dnf update # dnf install fedpkg wget make # cd home # wget wget https://kojipkgs.fedoraproject.org//packages/fpaste/0.4.0.1/1.fc32/src/fpaste-0.4.0.1-1.fc32.src.rpm # rpm2cpio fpaste-0.4.0.1-1.fc32.src.rpm |cpio -idm # fedpkg --release f32 local This works fine. Now upgrade with updates-testing. # dnf --enablerepo=updates-testing update # fedpkg -v --release f32 local Could not execute local: join() argument must be str, bytes, or os.PathLike object, not 'NoneType' Traceback (most recent call last): File "/usr/bin/fedpkg", line 11, in <module> load_entry_point('fedpkg==1.38', 'console_scripts', 'fedpkg')() File "/usr/lib/python3.8/site-packages/fedpkg/__main__.py", line 87, in main sys.exit(client.args.command()) File "/usr/lib/python3.8/site-packages/pyrpkg/cli.py", line 2164, in local self.sources() File "/usr/lib/python3.8/site-packages/pyrpkg/cli.py", line 2598, in sources self.cmd.sources(outdir) File "/usr/lib/python3.8/site-packages/pyrpkg/__init__.py", line 2075, in sources if not os.path.exists(self.sources_filename): File "/usr/lib/python3.8/site-packages/pyrpkg/__init__.py", line 1099, in sources_filename return os.path.join(self.path, self.layout.sources_file_template) File "/usr/lib64/python3.8/posixpath.py", line 90, in join genericpath._check_arg_types('join', a, *p) File "/usr/lib64/python3.8/genericpath.py", line 152, in _check_arg_types raise TypeError(f'{funcname}() argument must be str, bytes, or ' TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType' Suggested solution: https://pagure.io/rpkg/pull-request/512# workaround: in the directory containing 'specfile' execute `touch sources` before running `fedpkg local`. Thanks, the workaround works like a charm! Of course, I am looking forward to have it fixed in rpkg, as it seems like the sources file is not needed at all. But for the time being the workaround is very helpful. FEDORA-2020-689d384c29 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-689d384c29 FEDORA-2020-9243b572ea has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9243b572ea FEDORA-2020-081db3a145 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-081db3a145 FEDORA-EPEL-2020-52b7fffaf0 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-52b7fffaf0 FEDORA-EPEL-2020-b0b739248c has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-b0b739248c FEDORA-2020-081db3a145 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-081db3a145` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-081db3a145 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-689d384c29 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-689d384c29` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-689d384c29 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-52b7fffaf0 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-52b7fffaf0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-b0b739248c has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-b0b739248c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-9243b572ea has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-9243b572ea` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9243b572ea See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. The update fixed the problem for me on Fedora 32. Bug can be closed as fixed, but I am not sure which value is appropriate. So I leave it to someone else to mark as closed and to choose the correct reason. FEDORA-2020-1d768cb488 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-1d768cb488 FEDORA-2020-1d768cb488 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-1d768cb488` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-1d768cb488 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-689d384c29 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2020-3b36e3cee4 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-3b36e3cee4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-d4790c9c7f has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-d4790c9c7f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-1d768cb488 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2020-3b36e3cee4 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2020-d4790c9c7f has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. |