Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1872429
Summary: | login screen returns after live-iso user log (maybe LTO issue) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adriano <pandatitan.info> |
Component: | lxsession | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | 33 | CC: | awilliam, cwickert, fzatlouk, law, mtasaka, pandatitan.info |
Target Milestone: | --- | Keywords: | AutomationBackLog, Reopened |
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | AcceptedFreezeException | ||
Fixed In Version: | lxsession-0.5.5-4.fc33 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-10-23 22:12:27 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1766776, 1789115 |
Description
Adriano
2020-08-25 17:13:25 UTC
Would you check if the following scratch build cures this issue? https://koji.fedoraproject.org/koji/taskinfo?taskID=50218054 Well, still waiting for confirmation from the reporter, as far as I checked this issue, disabling lto for lxsession seems to work well. I will push this for F33 beta for now. I may find more proper solution later, but for now it should be okay. FEDORA-2020-d335b7b4ef has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d335b7b4ef Proposed as a Freeze Exception for 33-beta by Fedora user mtasaka using the blocker tracking app because: LXDE live spin is not functional. After login, LXDE session just closes and goes back to login screen. Law, would you give some advice for me about this issue? Thanks. Again, opting lxsession out LTO seems like the most prudent solution so as to not impact F33. I note that my .spec file scanner picked up the change this morning, so it's in my queue of things needing deeper investigation. THe toughest part here will probably be finding a way to test this quickly/easily without needing to "burn" a memory stick for every test, or even start up a new vm/container every time. But this is also one of the most concerning LTO issues in the queue as there's either a codegen issue in GCC or something undefined in the lxsession codebase that is being exposed by LTO. So closing as the immediate F33 issue is worked around and lxsession is showing up in my .spec file scanner as needing a deeper investigation. Thanks! FEDORA-2020-d335b7b4ef has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-d335b7b4ef` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d335b7b4ef See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. +3 votes for FE, setting as AcceptedFE. https://pagure.io/fedora-qa/blocker-review/issue/46 (In reply to Mamoru TASAKA from comment #2) > Well, still waiting for confirmation from the reporter, as far as I checked > this issue, disabling lto for lxsession seems to work well. > > I will push this for F33 beta for now. I may find more proper solution > later, but for now it should be okay. Hello Dear TASAKA... Sorry for delay your requests... I tested the newest ISO of Fedora LXDE dated 08/31-2020 and the problem reported initially still persists. I would like to add that I tested on several different machines and in different bios-firmware modes, including UEFI and CSM / Legacy and the result led to the same problems of returning the Login screen. Even without the LTO problem, the problem persists. Only in pure Openbox mode is the system able to log in normally. Well, Fedora-LXDE-Live-33-20200831.n.0 does not have lxsession-0.5.5-3.fc33 yet so if you just use Fedora-LXDE-Live-33-20200831.n.03 you will surely see this issue. Would you try the following? * Use Fedora-LXDE-Live-33-20200831.n.0 Live image, once trying graphical boot, then login fails and return to login screen * Change to CUI by ctrl-alt-F3, for example. * login as liveuser (liveuser has no password) * Download rpms from https://koji.fedoraproject.org/koji/buildinfo?buildID=1601782 * Install them by $ sudo rpm -Fvh *rpm * Go back to GUI (by ctrl-alt-F1), * and try graphical login again ? (In reply to Mamoru TASAKA from comment #10) > Well, Fedora-LXDE-Live-33-20200831.n.0 does not have lxsession-0.5.5-3.fc33 > yet so if you just use Fedora-LXDE-Live-33-20200831.n.03 you will surely see > this issue. > > > Would you try the following? > > * Use Fedora-LXDE-Live-33-20200831.n.0 Live image, once trying graphical > boot, then login fails and return to login screen > * Change to CUI by ctrl-alt-F3, for example. > * login as liveuser (liveuser has no password) > * Download rpms from > https://koji.fedoraproject.org/koji/buildinfo?buildID=1601782 > * Install them by $ sudo rpm -Fvh *rpm > * Go back to GUI (by ctrl-alt-F1), > * and try graphical login again > > ? Dear Mamoru TASAKA... I did all the recommended procedures just using pure Openbox instead of CUI (CTRL + ALT + FunctionKey) and it worked perfectly. From now on I will try to install LXDE 33 and see if other problems happen. I thank you in advance for your precious time dedicated to this problem. Okay, thank you for confirming. I think lxsession-0.5.5-3.fc33 will finally included in LXDE Fedora 33 beta spin. Mamoru: only if the update is submitted for stable, either by getting enough karma or waiting long enough. You should be able to submit it manually tomorrow or the day after, I think. Thanks! Hello, Adam: Will the updated lxsession rpm be included in next compose? (I've requested lxsession update to stable.) (In reply to Mamoru TASAKA from comment #14) > Hello, Adam: Will the updated lxsession rpm be included in next compose? > (I've requested lxsession update to stable.) Hi, since we're now in freeze, push requests to stable must be made manually. I've requested some push requests, including one for this bug: https://pagure.io/releng/issue/9725#comment-676218 , it should be in a compose after that request is fulfilled, probably in tomorrow's compose. (In reply to František Zatloukal from comment #15) > (In reply to Mamoru TASAKA from comment #14) > > Hello, Adam: Will the updated lxsession rpm be included in next compose? > > (I've requested lxsession update to stable.) > > Hi, > > since we're now in freeze, push requests to stable must be made manually. > > I've requested some push requests, including one for this bug: > https://pagure.io/releng/issue/9725#comment-676218 , it should be in a > compose after that request is fulfilled, probably in tomorrow's compose. I see... Thank you. FEDORA-2020-d335b7b4ef has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. Okay, Fedora-LXDE-Live-33-20200909.n.0 seems fine. Thank you, everyone. So after debugging, LTO issue was because of some mistake in the code I wrote... Ah. https://src.fedoraproject.org/rpms/lxsession/blob/f3e8a76425c15539fb9be4bbb2e6f3dd54a30537/f/lxsession-0.5.2-git9f8d6133-reload.patch#_30 So `gboolean xdpy_init()` does not "return TRUE;" at the last, then LTO seems to be thinking (from gdb) in xevent_init(), xdpy_init() will always return FALSE. As lxsession-0.5.5-3.fc33 is on F-33 buildtree already, no furture freeze-exception request is needed. FEDORA-2020-fa1ca4378a has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-fa1ca4378a So at this point this is not an LTO issue. Can we re-enable LTO in rawhide for lxsession? I've enabled LTO again on lxsession-0.5.5-4.fc3{3,4} . Thanks. The other thing that's odd here is I would have expected the compiler to warn for the code you referenced in c#19: +gboolean xdpy_init() +{ + dpy = XOpenDisplay( g_getenv("DISPLAY") ); + if( ! dpy ) + return FALSE; +} In particular I would have expected -Wreturn-type to have flagged this function as returning without a value. It should be enabled as part of -Wall IIRC. Yes, but during debugging, actually I've noticed (surprisingly) https://github.com/lxde/lxsession/blob/master/Makefile.am#L437 ... there is "-w", actually... So in fact all warnings are suppressed (I didn't notice this). In lxsession.spec, I've removed this "-w" to show warnings. FEDORA-2020-fa1ca4378a has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-fa1ca4378a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-fa1ca4378a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-fa1ca4378a has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |