Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 187313 (perl-Authen-Radius)
Summary: | Review Request: perl-Authen-Radius | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Thienemann <andreas> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | clem.oudot |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-04-13 12:02:09 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 187314 | ||
Bug Blocks: | 163779, 187326 |
Description
Andreas Thienemann
2006-03-29 22:25:40 UTC
I'm not a Radius user but I can do a review. The package builds fine in mock (devel branch) and rpmlint is silent. Issues: BuildRequires: perl is not allowed; cpanspec should be able to generate a proper specfile that doesn't do this. There's no point in the BuildRequires: for perl(IO) and perl(Digest::MD5) as these are part of base perl, but I don't supposed there's any harm in keeping them. The only thing that's strictly necessary is BuildRequires: perl(Data::HexDump) Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and conforms to the Perl template. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: 8427f931a4e0e689ecf8ddf30e5a0ea7 RadiusPerl-0.12.tar.gz 8427f931a4e0e689ecf8ddf30e5a0ea7 RadiusPerl-0.12.tar.gz-srpm * package builds in mock. X BuildRequires: perl not permitted. * no shared libraries. * package is not relocatable. * owns the directory it creates. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. * The package owns %{perl_vendorlib}/Authen, which will probably also be owned by any module under the Authen:: namespace. However, there are no dependencies which could create this directory so there is no alternative but for this package to own it. (In reply to comment #1) > BuildRequires: perl is not allowed; cpanspec should be able to generate a proper > specfile that doesn't do this. Removed. > There's no point in the BuildRequires: for perl(IO) and perl(Digest::MD5) as > these are part of base perl, but I don't supposed there's any harm in keeping > them. Removed. Thx for the review. Upgraded files are available at: http://home.bawue.de/~ixs/perl-Authen-Radius/ Looks good and builds properly. BTW, you left the perl(IO) and perl(Digest::MD5) buildreqs in, but this isn't a blocker. APPROVED *** Bug 1472175 has been marked as a duplicate of this bug. *** perl-Authen-Radius-0.26-4.el7 perl-Data-HexDump-0.02-26.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-d0f7e44663 perl-Authen-Radius-0.26-4.el7, perl-Data-HexDump-0.02-26.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |