Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1874462

Summary: Kill switch for Lenovo laptops non-functional
Product: [Fedora] Fedora Reporter: Benjamin Berg <bberg>
Component: thermaldAssignee: Benjamin Berg <bberg>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: awilliam, bberg, besser82, ckellner, mpearson
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/intel/thermal_daemon/pull/267
Whiteboard: AcceptedFreezeException
Fixed In Version: thermald-2.3-2.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-09-08 17:04:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1766776    

Description Benjamin Berg 2020-09-01 12:27:41 UTC
thermald ships a kill-switch for certain Lenovo models. Unfortunately, this kill-switch has a simple bug that should be fixed.

Without this kill-switch we risk the thermal management of the firmware and thermald to interfering with each other. This affects newer Lenovo models (I believe as of two years old), which also allow changing the performance mode using Fn+{HLM} or similar.

This is particular important as the firmware enforces "lap-mode" which can prevent injuries (i.e. the laptop getting hot enough to damage human skin).

Comment 1 Fedora Blocker Bugs Application 2020-09-01 12:32:10 UTC
Proposed as a Freeze Exception for 33-beta by Fedora user benzea using the blocker tracking app because:

 Avoid potential thermal management issues on some Lenovo machines.

The fix is trivial, it is just a path that was slightly wrong in thermald's detection code.

Comment 2 Adam Williamson 2020-09-01 15:25:44 UTC
We have +3 votes in https://pagure.io/fedora-qa/blocker-review/issue/57 , setting accepted. Please go ahead and build the fix and submit an update marked as fixing this bug. Thanks!

Comment 3 Fedora Update System 2020-09-01 16:19:59 UTC
FEDORA-2020-0eecf4985f has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0eecf4985f

Comment 4 Fedora Update System 2020-09-01 21:49:04 UTC
FEDORA-2020-0eecf4985f has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-0eecf4985f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0eecf4985f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2020-09-08 17:04:14 UTC
FEDORA-2020-0eecf4985f has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.