Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1877886

Summary: Review Request: python-vsure - Read and change status of verisure devices
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-26 09:31:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1269538    

Description Fabian Affolter 2020-09-10 16:35:54 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-vsure.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-vsure-1.6.0-1.fc32.src.rpm

Project URL: http://github.com/persandstrom/python-verisure

Description:
A Python module for reading and changing status of verisure devices
through mypages.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=51151282

rpmlint output:
$ rpmlint python-vsure-1.6.0-1.fc32.src.rpm 
python-vsure.src: W: spelling-error Summary(en_US) verisure -> verdure
python-vsure.src: W: spelling-error %description -l en_US verisure -> verdure
python-vsure.src: W: spelling-error %description -l en_US mypages -> my pages, my-pages, pages
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint python3-vsure-1.6.0-1.fc32.noarch.rpm 
python3-vsure.noarch: W: spelling-error Summary(en_US) mypages -> my pages, my-pages, pages
python3-vsure.noarch: W: spelling-error %description -l en_US mypages -> my pages, my-pages, pages
python3-vsure.noarch: W: no-manual-page-for-binary vsure
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-09-10 21:59:50 UTC
 - Bump to 1.6.1 and install the license


 - License ok
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Fabian Affolter 2020-09-11 07:46:57 UTC
(In reply to Robert-André Mauchin 🐧 from comment #1)
>  - Bump to 1.6.1 and install the license

Will do. Thanks for the review.

Comment 3 Gwyn Ciesla 2020-09-11 14:33:44 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-vsure

Comment 4 Fedora Update System 2020-09-13 09:53:37 UTC
FEDORA-2020-371ae1410d has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-371ae1410d