Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1877946

Summary: Review Request: pyserial-asyncio - Asynchronous Python Serial Port Extension
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-09-25 16:57:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1877961, 1879765, 1879945, 1880640, 1880645, 1880663, 1880665    

Description Fabian Affolter 2020-09-10 20:48:18 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/pyserial-asyncio.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/pyserial-asyncio-0.4-1.fc34.src.rpm

Project URL: https://github.com/pyserial/pyserial-asyncio

Description:
Async I/O extension package for the Python Serial Port Extension.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=51168310

rpmlint output:
$ rpmlint pyserial-asyncio-0.4-1.fc34.src.rpm 
pyserial-asyncio.src: W: spelling-error %description -l en_US Async -> Sync, A sync
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint python3-pyserial-asyncio-0.4-1.fc34.noarch.rpm 
python3-pyserial-asyncio.noarch: W: spelling-error %description -l en_US Async -> Sync, A sync
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-09-10 21:54:04 UTC
Missing pytest:

+ /usr/bin/pytest -v test
/var/tmp/rpm-tmp.1d0MTv: line 33: /usr/bin/pytest: No such file or directory

BuildRequires:  python3dist(pytest)

 - Remove shebang:

python3-pyserial-asyncio.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/serial_asyncio/__init__.py 644 /usr/bin/env python3


Then:

 - Latest version packaged
 - License ok
 - Builds in mock
 - Tests pass
 - Conforms to Packaging Guidelines

Package approved. Fix the aforementioned issues before import.

Comment 2 Gwyn Ciesla 2020-09-11 14:42:52 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/pyserial-asyncio

Comment 3 Fedora Update System 2020-09-14 13:41:33 UTC
FEDORA-2020-75e2371e58 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-75e2371e58

Comment 4 Fedora Update System 2020-09-14 15:11:37 UTC
FEDORA-2020-75e2371e58 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-75e2371e58 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-75e2371e58

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2020-09-25 16:57:43 UTC
FEDORA-2020-75e2371e58 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.