Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 187797

Summary:	Review Request: perl-IO-Interface - Perl extension for accessing network card configuration information
Product:	[Fedora] Fedora	Reporter:	Jose Pedro Oliveira <jose.p.oliveira.oss>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-04-21 22:29:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Jose Pedro Oliveira 2006-04-03 17:08:00 UTC

Spec Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-IO-Interface.spec

SRPM Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-IO-Interface-0.98-1.src.rpm

Description:
IO::Interface adds methods to IO::Socket objects that allows them to
be used to retrieve and change information about the network
interfaces on your system.  In addition to the object-oriented access
methods, you can use a function-oriented style.

Comment 1 Jason Tibbitts 2006-04-07 22:32:30 UTC

Package builds fine in mock and rpmlint is silent.

Issues: BuildRequires: perl is not allowed.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   91d5029a32302aa02414c9c8e3353cec  IO-Interface-0.98.tar.gz
   91d5029a32302aa02414c9c8e3353cec  IO-Interface-0.98.tar.gz-srpm
* package builds in mock.
X BuildRequires: perl not permitted.
* a shared library is present, but it is not in the library search path and
there is no need to run ldconfig.
* package is not relocatable.
* owns the directory it creates.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* The package owns %{perl_archlib}/IO, which will probably also be owned by
any arch-specific module under the IO:: namespace.  However, none of the
dependencies create this directory so there is no alternative but for this
package to own it.

Comment 2 Jason Tibbitts 2006-04-21 18:03:12 UTC

The steering committee has changed the rule and allowed BR: perl, so I drop my
objection.

APPROVED

Comment 3 Jose Pedro Oliveira 2006-04-21 22:29:28 UTC

Thanks for the review.

Built for FC-4, FC-5, and devel.