Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 188527

Summary:	Review Request: perl-Module-Load-Conditional
Product:	[Fedora] Fedora	Reporter:	Steven Pritchard <steve>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-04-19 14:49:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	188505, 188519, 188523
Bug Blocks:	163779, 189042, 189043, 189048

Description Steven Pritchard 2006-04-10 21:16:11 UTC

Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Module-Load-Conditional/perl-Module-Load-Conditional.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Module-Load-Conditional-0.08-1.src.rpm
Description:
Module::Load::Conditional provides simple ways to query and possibly load
any of the modules you have installed on your system during runtime.

Comment 1 Jason Tibbitts 2006-04-12 02:59:59 UTC

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   9e2a706b6511651ca4eb6de0c4c89a12  Module-Load-Conditional-0.08.tar.gz
   9e2a706b6511651ca4eb6de0c4c89a12  Module-Load-Conditional-0.08.tar.gz-srpm
* BuildRequires are proper.
* package builds in mock.
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

Comment 2 Steven Pritchard 2006-04-19 14:49:34 UTC

Imported into CVS and packages built.