Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189043
| Summary: | Review Request: perl-File-Fetch | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steven Pritchard <steve> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-21 21:56:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 188505, 188523, 188527, 189041 | ||
| Bug Blocks: | 163779, 189048 | ||
|
Description
Steven Pritchard
2006-04-14 23:59:33 UTC
Issues: Three buildrequires duplicate what RPM detects automatically. In the changelog I see that you deleted one duplicate Requires: statement; why that one and not the three others. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and conforms to the Perl template. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: 53135c09fa15e9cb0a980b153b9634e0 File-Fetch-0.07.tar.gz 53135c09fa15e9cb0a980b153b9634e0 File-Fetch-0.07.tar.gz-srpm * BuildRequires are proper. * package builds in mock. * rpmlint is silent. X final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directory it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is (essentially) not present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. In light of other discussion I'll drop my objection. APPROVED. Imported, branches created, and builds requested. |