Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189263
| Summary: | Review Request: rsibreak | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Roland Wolters <roland.wolters> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | orion |
| Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-06-20 23:43:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Roland Wolters
2006-04-18 17:37:51 UTC
- rpmlint checks return clean - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - locales handled properly - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file There really is not a much better rpm group. APPROVED I'll sponsor if still needed, apply for cvsextras. Note that when the package builds you can inform the rsibreak authors about the Extras package. I have already applied for sponsorship, but as stated in Bug 187818, my account role status is described as "in progress", the Sponsor field says "unneeded", and I can't add myself to the cvsextras group. I will post here again as soon as this problem is fixed. I worked with an admin on IRC to get to the bottom of this and everything should be moving now. John, the sponsorship request should be in your mailbox. We'll see, but thank you for helping.
Anyway, today the new version of rsibreak was released, here is the newest
spec file and srpm, I updated the changelog (new version, changed my e-mail to
the one used here) as well as the package path (to the new version) and
version. Also some of the icon files were moved to other directories (from
%{_datadir}/icons/ to %{_datadir}/apps/rsibreak/icons) upstream so I corrected
the pathes there, to.
The new files can be found here:
http://www.personal.uni-jena.de/~p1woro/fedorarpms/rsibreak.spec
http://www.personal.uni-jena.de/~p1woro/fedorarpms/rsibreak-0.7.1-1.src.rpm
The old spec file can be found here:
http://www.personal.uni-jena.de/~p1woro/fedorarpms/rsibreak.spec.release1
Source0 is actually http://www.rsibreak.org/images/e/e2/Rsibreak-0.7.1.tar.bz2, but checks out anyway. Still approved, and sponsored. Go ahead and build. Thank you very much for the help and the sponsorship! Here are the build-logs: http://buildsys.fedoraproject.org/build-status/job.psp?email=wolters.liste@gmx.net&uid=11320 http://buildsys.fedoraproject.org/build-status/job.psp?email=wolters.liste@gmx.net&uid=11318 Close as next release. Package Change Request ====================== Package Name: rsibreak Updated Fedora CC: Rex Dieter (rdieter.edu) Please make him co-maintainer. This review is used for this procedure because it was stated to do so: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure Package Change Request ====================== Package Name: rsibreak New Branches: epel7 Owners: orion InitialCC: Git done (by process-git-requests). |