Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189690
Summary: | Review Request: swh-plugins | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Anthony Green <green> |
Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-04-24 15:07:27 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Anthony Green
2006-04-23 04:17:42 UTC
I'll do a formal review on this later today. PUBLISH +1 MD5Sums: 1d8418b85034ee9153c726c4c7188a1a swh-plugins-0.4.14.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * All desired features are enabled * Builds fine in Mock. * Package installs and uninstalls cleanly on FC4. Notes: * rpmlint gives the following, which are fairly self-explanatory to fix: W: swh-plugins summary-ended-with-dot A set of audio plugins for LADSPA. E: swh-plugins zero-length /usr/share/doc/swh-plugins-0.4.14/NEWS * The BuildRequirements for pkgconfig, gettext, libtool, bison, and perl-XML-Parser are unnecessary since Mock should pulls these in the minimum chroot. * Don't package the INSTALL doc, since it's the generic GNU Autotools file. (In reply to comment #2) > * Package installs and uninstalls cleanly on FC4. Whoops, meant to write FC5. Thanks for looking at this. (In reply to comment #2) > * rpmlint gives the following, which are fairly self-explanatory to fix: > W: swh-plugins summary-ended-with-dot A set of audio plugins for LADSPA. > E: swh-plugins zero-length /usr/share/doc/swh-plugins-0.4.14/NEWS Fixed. > * The BuildRequirements for pkgconfig, gettext, libtool, bison, and > perl-XML-Parser are unnecessary since Mock should pulls these in the minimum > chroot. Ok, I've removed these. But shouldn't the Exceptions section of the packaging guidelines mention these packages as well? > * Don't package the INSTALL doc, since it's the generic GNU Autotools file. Right. Updated bits here: Spec URL: http://people.redhat.com/green/FE/FC5/swh-plugins.spec SRPM URL: http://people.redhat.com/green/FE/FC5/swh-plugins-0.4.14-2.src.rpm No need to post the revised spec & srpm. I already changed the status of this to FE-ACCEPT, since most of the changes were minor and could be fixed when you imported this into CVS. (In reply to comment #5) > No need to post the revised spec & srpm. Ok. Thanks for your quick response. I've imported this package and requested an FC-5 branch. I'll close this with NEXTRELEASE now. Something ought to be done about %{_datadir}/ladspa/rdf/* however, since currently, the directories are orphaned. Depending on administrator's umask, they can be created with insufficient file access permissions. The directories don't belong in the ladspa package and not in to liblrdf either. So it would be fine if every ladspa plugin package owned them. |