Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189727 (scribes)
Summary: | Review Request: Scribes | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Gordon <peter> |
Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-05-08 23:22:41 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Peter Gordon
2006-04-23 23:56:14 UTC
Updated to 0.2.4.3-2 to include small patch to rid the setup script of the unnecessary gconf stuff and also to fix some of the spacing inconsistencies in the spec. SRPM: http://thecodergeek.com/downloads/fedora/scribes-0.2.4.3-1.src.rpm Spec: http://thecodergeek.com/downloads/fedora/scribes.spec Thanks. MD5Sums: 5031eaa0ef8817ea32d390fc4d26ceda scribes-0.2.4.3.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * Desktop entry is fine * All directories are owned by this or other packages * All necessary BuildRequires listed. * All desired features are enabled * Builds fine in mock. Minor: * Non-blocker rpmlint errors, that are being addressed upstream: E: scribes zero-length /usr/share/gnome/help/scribes/C/figures/scribes_status.png E: scribes zero-length /usr/share/gnome/help/scribes/C/figures/scribes_editing.png Bad: * In your schemas scriptlets you can drop the 'killall -HUP gconfd-2 || :', since it's no longer needed in FC5 and above. * Instead of Requires for yelp, you should be using scrollkeeper, and it's associated scriptlets. http://fedoraproject.org/wiki/ScriptletSnippets#head-3c9f517f0cd4aaabb369a8805226d85dc2f02793 Thanks for the review and suggestions, Brian. I've uploaded and updated version to address these: Spec: http://thecodergeek.com/downloads/fedora/scribes.spec SRPM: http://thecodergeek.com/downloads/fedora/scribes-0.2.4.3-3.src.rpm The changes you made looks good, go ahead and import it into FE CVS. PUBLISH +1, full review in comment #2. Packages built successfully for Fedora Extras 5 and Devel; and they should be pushed to the mirrors shortly. Thanks for your time and advice. Please do not remove the FE-ACCEPT blocker. Thanks. |