Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1897544
| Summary: | python-crypto fails to build with Python 3.10: SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomáš Hrnčiar <thrnciar> |
| Component: | python-crypto | Assignee: | Paul Howarth <paul> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | athmanem, mhroncok, paul, thrnciar |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-crypto-2.6.1-33.fc34 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-21 14:44:10 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1890881 | ||
python-crypto is no longer maintained upstream but there is an active fork, python-pycryptodomex, which is also included in Fedora, and when that is fixed for this issue, I should be able to use the same fix for python-crypto. Of course it would be better if python-crypto users in Fedora migrated to python-pycryptodomex and then we could get rid of python-crypto altogether. Hmm, looks like this code was refactored out of python-pycryptodomex a long time ago so I'll have to think again about what to do about this. Looks like ansible does not build in our copr because pytohn3-crypto is missing. I'll check if the build dependency is really needed, because on runtime, it uses cryptography. Ansible has tests that use this :( We could skip those, but I am not sure if safe. Bumping the severity here, ansible is important. Please let us know if you need help figuring out the fix. Should be fixed in python-crypto-2.6.1-33.fc34 Thank You, Paul! |
python-crypto fails to build with Python 3.10.0a2. Traceback (most recent call last): File "build/lib.linux-x86_64-3.10/Crypto/SelfTest/Cipher/common.py", line 206, in runTest cipher = self.module.new(a2b_hex(self.key), self.module.MODE_CTR, counter=ctr) File "build/lib.linux-x86_64-3.10/Crypto/Cipher/AES.py", line 95, in new return AESCipher(key, *args, **kwargs) File "build/lib.linux-x86_64-3.10/Crypto/Cipher/AES.py", line 59, in __init__ blockalgo.BlockAlgo.__init__(self, _AES, key, *args, **kwargs) File "build/lib.linux-x86_64-3.10/Crypto/Cipher/blockalgo.py", line 139, in __init__ self._cipher = factory.new(key, *args, **kwargs) SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats https://docs.python.org/3.10/whatsnew/3.10.html#id2 The PY_SSIZE_T_CLEAN macro must now be defined to use PyArg_ParseTuple() and Py_BuildValue() formats which use #: es#, et#, s#, u#, y#, z#, U# and Z#. See Parsing arguments and building values and the PEP 353. https://docs.python.org/3.10/c-api/arg.html#arg-parsing https://www.python.org/dev/peps/pep-0353 https://bugs.python.org/issue40943 For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01757388-python-crypto/ For all our attempts to build python-crypto with Python 3.10, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-crypto/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/ Let us know here if you have any questions. Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.