Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189827
Summary: | Review Request: perl-PBS - Perl binding for the Portable Batch System client library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Garrick Staples <garrick> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | steve.traylen |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-04-25 20:52:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Garrick Staples
2006-04-24 22:05:58 UTC
Issues: Please use the full URL in the Source tag whenever possible. If you do this, spectool can grab the upstream sources straight from the 'net. Since there's nothing else wrong with this package, I'll go ahead and approve and you can fix it when you check in. Review: * package meets naming and packaging guidelines. X specfile is properly named, is cleanly written and uses macros consistently, but Source0: does not refer to the full URL of the source file. * license field matches the actual license. * license is open source-compatible and both Artistic and GPL texts are included in the package. * source files match upstream: ab776b32945db7832acfeab5fd5cfbb6 perl-PBS-0.31.tar.gz ab776b32945db7832acfeab5fd5cfbb6 perl-PBS-0.31.tar.gz-srpm * BuildRequires are proper. * package builds in mock (development, i386 and x86_64). * rpmlint is silent. * final provides and requires are sane. O shared libraries are present, but they are internal to Perl so there is no reason to run ldconfig. * package is not relocatable. * owns the directory it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED (but please fix the Source0 URL) Thanks! I've added it to CVS with a full Source0 URL. Package Change Request ====================== Package Name: perl-PBS New Branches: EL-4 EL-5 EL-6 Owners: stevetraylen CVS done (by process-cvs-requests.py). |