Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 189830

Summary:	Review Request: xmms-scrobbler - Audioscrobbler plugin for XMMS
Product:	[Fedora] Fedora	Reporter:	Andreas Thienemann <andreas>
Component:	Package Review	Assignee:	David Cantrell <dcantrell>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-04-27 16:34:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Andreas Thienemann 2006-04-24 22:29:28 UTC

Spec URL: http://home.bawue.de/~ixs/xmms-scrobbler/xmms-scrobbler.spec
SRPM URL: http://home.bawue.de/~ixs/xmms-scrobbler/xmms-scrobbler-0.3.6-1.src.rpm
Description:
This is an audioscrobbler xmms plugin.
Audioscrobbler will send the name of every song you play on your computer
to Last.fm. This effortlessly populates your profile to play radio you like
and make personalised recommendations!

Comment 1 Jesse Keating 2006-04-27 04:01:50 UTC

Bad:
- Buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Question:
- Will your defatter make the docs files be installed with 0755 permissions?  If
so, this isn't right.

Haven't tested mock building or rpmlint, will check tomorrow.

Comment 2 Andreas Thienemann 2006-04-27 12:18:29 UTC

Updated files at http://home.bawue.de/~ixs/xmms-scrobbler/
The permission issue is fixed as well as it came from the template-spec I copied.

Comment 3 Jesse Keating 2006-04-27 15:55:11 UTC

Changes look good, rpmlint is silent, builds on i386/x86_64, I think we're good
to go.

ACCEPT.

Comment 4 Andreas Thienemann 2006-04-27 16:34:59 UTC

Thx for the review.

Package has been updated to current 0.3.8 (upstream changed urls. gnarghl.) and
build. closing as nextrelease.

Comment 5 Christian Iseli 2007-01-01 22:38:57 UTC

Fix typo.