Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 190304
| Summary: | Review Request: mtd-utils | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Woodhouse <dwmw2> |
| Component: | Package Review | Assignee: | David Woodhouse <dwmw2> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-05-02 12:30:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
David Woodhouse
2006-04-30 21:27:27 UTC
I'll review this tonight. At first glance, it seems fine. Completed MUST items:
- rpmlint output:
[jwboyer@vader i386]$ rpmlint -v mtd-utils-1.0.0-1.i386.rpm
I: mtd-utils checking
[jwboyer@vader i386]$
- named according to the Package Naming guidlines
- spec file name matches %{name}.spec
- meets Packaging Guidelines
- licensed under the GPL
- License: field matches
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
- source SHA1 sum matches upstream
- compiles and builds on x86
Two small nits:
- The package should probably throw a Requires: zlib and BuildRequires:
zlib-devel in the spec file.
- The upstream source lacks a copy of the license text. It would be nice if the
upstream source could include this at some point, but is not required.
I'm assuming David will fixup the zlib issues. After that is done, I consider
this approved.
Added BuildRequires: zlib-devel Added COPYING (and also upstream from your git tree) Not added Requires: zlib since that's automatic. Imported and built. Thanks. |