Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1903075
Summary: | python-zarr fails to build with Python 3.10 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tomáš Hrnčiar <thrnciar> |
Component: | python-zarr | Assignee: | Elliott Sales de Andrade <quantum.analyst> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | bussonniermatthias, mhroncok, pviktori, python-sig, quantum.analyst, thrnciar, vstinner |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | python-zarr-2.7.0-1.fc35 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2021-04-06 00:51:02 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1904386 | ||
Bug Blocks: | 1890881 |
Description
Tomáš Hrnčiar
2020-12-01 09:29:35 UTC
Many failures are: E AttributeError: '_cffi_backend.buffer' object has no attribute 'tobytes' > E AttributeError: '_cffi_backend.buffer' object has no attribute 'tobytes' I checked cffi archives and it seems like this type never had a tobytes() method. I guess that previously, zarr didn't get a '_cffi_backend.buffer' object, but another type. Maybe buffer[:] or bytes(buffer) can be used instead. I don't understand what is the "ffi" module in the CFFI documentation. I found ffi.buffer documentation, not sure if it's related: https://cffi.readthedocs.io/en/latest/ref.html#ffi-buffer-ffi-from-buffer New version of zarr - 2.6.1 is now available. I tried to rebuild it in our Python3.10 COPR, but the errors are still present. https://copr.fedorainfracloud.org/coprs/g/python/python3.10/build/1810021/ I reported the test failures to upstream: https://github.com/zarr-developers/zarr-python/issues/669 That is likely an issue with Python-LMDB; My redhat-foo is not that good, but it looks like from googling that Python-lmdb on EPEL is 0.92 (from 2016), and that there was many releases (8) since then, last one August 28 2020. Can you confirm your version of Python-lmdb ? Note that zarr-python failure due to lmdb are non-fatal as they will affect only people using lmdb stores. You can also just not-install python-lmdb when running the test suite; as it will automatically skip the lmdb test when it is not present. I'm happy to add a conditional version check in zarr on Python and Python-LMDB version that skip the test on 3.10 with a known incompatible version of LMDB if that can help. Thank you for the pointer! Indeed, python-lmdb is at 0.92 even in Fedora. Here's a PR to update it to 1.0.0: https://src.fedoraproject.org/rpms/python-lmdb/pull-request/1 Indeed, python-zarr builds with Python 3.10 and python-lmdb 1.0.0: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/build/1810977/ Ok, that is great. We've also added a workaround on zarr-python, so next release might not need python-lmdb 1.0.0 to work. Merging the workaround have closed the upstream issue; and as you point out that with LMDB 1.0.0 build appear to succeed; I'm going to assume it's ok to keep the upstream bug closed. Let me know if you need to re-open, and/or if there is anything we can do to make your life easier like notifying you on new release, or including specific patches/files in the source. Yes, it's definitely OK to leave it closed. Thank you for investigating this one! We get release notifications from PyPI. (It's set up for zarr; I've recommended it to Fedora's lmdb maintainer as well.) This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle. Changing version to 34. The new zarr is out with a workaround, and the Python 3.10 copr has been passing. |