Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 190310

Summary:	Review Request: perl-File-Find-Rule-PPI - Add support for PPI queries to File::Find::Rule
Product:	[Fedora] Fedora	Reporter:	Jose Pedro Oliveira <jose.p.oliveira.oss>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-05-06 01:54:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	190308
Bug Blocks:	163779

Description Jose Pedro Oliveira 2006-05-01 00:18:24 UTC

Spec URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-File-Find-Rule-PPI.spec

SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-File-Find-Rule-PPI-0.03-1.src.rpm

Description:
File::Find::Rule::PPI allows you to integrate PPI content queries into
your File::Find::Rule searches.

Comment 1 Jason Tibbitts 2006-05-01 20:10:06 UTC

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
follows the Perl template.
* license field matches the actual license.
* license is open source-compatible; text is included in the package.
* source files match upstream:
   a63dfd3b079258f4766b6445c1614b0f  File-Find-Rule-PPI-0.03.tar.gz
   a63dfd3b079258f4766b6445c1614b0f  File-Find-Rule-PPI-0.03.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=3, Tests=7,  1 wallclock secs ( 0.24 cusr +  0.09 csys =  0.33 CPU)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

Comment 2 Jose Pedro Oliveira 2006-05-06 01:54:41 UTC

Thanks for the review.

Imported and built for FC-5 and devel.