Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 190346
Summary: | Review Request: vdr-subtitles - DVB subtitles plugin for VDR | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <scop> |
Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | opensource |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-12 09:22:35 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 190343 | ||
Bug Blocks: | 163779 |
Description
Ville Skyttä
2006-05-01 14:07:04 UTC
http://cachalot.mine.nu/5/SRPMS/vdr-subtitles-0.4.0-1.src.rpm * Sat May 6 2006 Ville Skyttä <ville.skytta at iki.fi> - 0.4.0-1 - 0.4.0. The URL to the spec file is missing. See bug 190344 comment 2. To add my 2 cents, I also like to have .spec files linked to reviews. It does make it easier to see whats going on with a package without having to pull down and unpack the src.rpm. That said, here's a review of this package: OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 74780f7f296f1feac13f4358b97bd2f3 vdr-subtitles-0.4.0.tgz 74780f7f296f1feac13f4358b97bd2f3 vdr-subtitles-0.4.0.tgz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. x86_64/i386 - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. The debian patch at: http://zap.tartarus.org/~ds/debian/dists/unstable/main/source/vdr-plugin-subtitles_0.3.11-1.ds.diff.gz is old. Looks like there is a 0.4.0 version there now. Perhaps updating to that will let you remove a sed in there for the version? I don't see any blockers however, so this package is APPROVED. Don't forget to close this NEXTRELEASE once it's been imported and built. I had the "ds" patch updated already in a local copy, now done in the imported package too. Built for devel, owners list and comps updated, FC-5 and FC-6 branches requested. Thanks! |