Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1912931

Summary: coccinelle fails to build with Python 3.10: Cannot resolve _Py_fopen
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: coccinelleAssignee: Richard W.M. Jones <rjones>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mhroncok, rjones, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-07 07:33:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1890881    

Description Tomáš Hrnčiar 2021-01-05 16:02:21 UTC
coccinelle fails to build with Python 3.10.0a4.

/lib64/libpython3.10.so.1.0 returned Cannot resolve _Py_fopen

bpo-32381: Remove the private _Py_fopen() function which is no longer needed. Use _Py_wfopen() or _Py_fopen_obj() instead.

https://docs.python.org/3.10/whatsnew/changelog.html#c-api

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01859535-coccinelle/

For all our attempts to build coccinelle with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/coccinelle/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2021-01-05 16:06:42 UTC
coccinelle-d0fd4c7dfa70763870914eedee7022fa35f700e2/bundles/pyml/pyml-current/pyml_stubs.c

    if (version_major >= 3) {
        Python__Py_fopen = resolve("_Py_fopen");
    }

Comment 2 Richard W.M. Jones 2021-01-05 18:53:53 UTC
Hmm, I thought I fixed the Python 3.10 things (bug 1896393).  Or is Python 3.10
still in development?

Anyway this fix is a bit beyond me.  Replacing the call with _Py_wfopen
appears like it will work, but what I'm not sure is why on earth the code
is calling these internal python functions in the first place instead of
using regular fopen.  Indeed for Python 2 it *was* using regular fopen.

I will ask upstream.

Comment 3 Richard W.M. Jones 2021-01-05 18:58:42 UTC
Not in the archive yet but should appear here:
https://systeme.lip6.fr/pipermail/cocci/2021-January/thread.html

Comment 4 Miro Hrončok 2021-01-05 20:31:51 UTC
> Or is Python 3.10 still in development?

Yes, it is. See https://fedoraproject.org/wiki/Changes/Python3.10#Important_dates_and_plan

Comment 5 Ben Cotton 2021-02-09 15:37:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 6 Miro Hrončok 2021-06-04 20:14:40 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 7 Richard W.M. Jones 2021-06-06 22:03:01 UTC
This is fixed upstream, but we might have to update coccinelle or backport
the upstream patch.  Mailing list thread:

https://lore.kernel.org/cocci/ow4mtxjyqhx.fsf@inria.fr/

Comment 8 Richard W.M. Jones 2021-06-07 07:33:10 UTC
I've now actually checked and it seems cocci was rebuilt successfully:

https://koji.fedoraproject.org/koji/buildinfo?buildID=1759679

against:

DEBUG util.py:446:   python3-devel                          x86_64  3.10.0~b2-3.fc35               build  205 k

so there should be nothing to do here.