Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191607
Summary: | Review Request: lineak-xosdplugin - Onscreen display support for lineakd | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Petersen <lists> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-06-03 09:14:37 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 191604 | ||
Bug Blocks: | 163779 |
Description
Chris Petersen
2006-05-13 19:47:28 UTC
Shuffling files around on my server, and making a few changes to bring things up to par. http://rpm.forevermore.net/lineak/lineak_xosdplugin.spec http://rpm.forevermore.net/lineak/lineak_xosdplugin-0.8.4-2.src.rpm More changes, ala request: http://rpm.forevermore.net/lineak/lineak-xosdplugin.spec http://rpm.forevermore.net/lineak/lineak-xosdplugin-0.8.4-3.src.rpm Just got a build failure: /bin/sh ../libtool --silent --mode=link --tag=CXX g++ -Wnon-virtual-dtor -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -O2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common -LNONE -lX11 -lXext -ldl -o xosdplugin.la -rpath /usr/lib64/lineakd/plugins -module -avoid-version xosdplugin.lo xosdctrl.lo -lX11 -llineak -L/usr/lib64 -lxosd -lpthread -lXext -lX11 -lXinerama -lxosd -llineak ../libtool: line 1573: cd: NONE: No such file or directory libtool: link: cannot determine absolute directory name of `NONE' make[2]: *** [xosdplugin.la] Error 1 I'm not really sure what's up here; I'll try to take a closer look later. The issue was simply a missing BuildRequires: libXt-devel; I'll add it and proceed with the review. Note that the ChangeLog file has zero length and should not be packaged: E: lineak-xosdplugin zero-length /usr/share/doc/lineak-xosdplugin-0.8.4/ChangeLog These are pretty quick fixes, so I'll go ahead and approve and you can fix them when you check in. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: 36f519b21e7c7257bd9af6543f7fd9fc lineak_xosdplugin-0.8.4.tar.gz 36f519b21e7c7257bd9af6543f7fd9fc lineak_xosdplugin-0.8.4.tar.gz-srpm * latest version is being packaged. O BuildRequires are proper (after adding libXt-devel as above). O package builds in mock (development, x86_64) (after fixing BRs.) X rpmlint complains about ChangeLog. * final provides and requires are sane: lineak_xosdplugin = 0.8.4 xosdplugin.so()(64bit) lineak-xosdplugin = 0.8.4-4.fc6 - libX11.so.6()(64bit) libXext.so.6()(64bit) libXinerama.so.1()(64bit) libdl.so.2()(64bit) liblineak.so.0()(64bit) libxosd.so.2()(64bit) lineakd = 0.8.4 xosd >= 2.1 * one shared library is present, but it is internal to lineakd and so there's no need to call ldconfig. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present; no test suite upstream. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED, but please don't package the zero length ChangeLog and don't forget to add the BR: libXt-devel so the package will build. |