Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1923386
Summary: | rocksdb: FTBFS in Fedora rawhide/f34 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Fedora Release Engineering <releng> | ||||||||
Component: | rocksdb | Assignee: | Jonny Heggheim <hegjon> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | unspecified | Docs Contact: | |||||||||
Priority: | unspecified | ||||||||||
Version: | 34 | CC: | hegjon, law, mmuzila, msebor, msebor | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | rocksdb-6.15.5-1.fc34 | Doc Type: | If docs needed, set a value | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2021-03-19 20:02:55 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 1868278 | ||||||||||
Attachments: |
|
Description
Fedora Release Engineering
2021-02-01 16:43:05 UTC
Created attachment 1753188 [details]
build.log
file build.log too big, will only attach last 32768 bytes
Created attachment 1753189 [details]
root.log
file root.log too big, will only attach last 32768 bytes
Created attachment 1753190 [details]
state.log
This is an upstream GCC bug tracked in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98465. It was also reported in bug 1909564. A patch for it was posted for review on 1/19: https://gcc.gnu.org/pipermail/gcc-patches/2021-January/563862.html This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle. Changing version to 34. Dear Maintainer, your package has an open Fails To Build From Source bug for Fedora 34. Action is required from you. If you can fix your package to build, perform a build in koji, and either create an update in bodhi, or close this bug without creating an update, if updating is not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. If you have already fixed this issue, please close this Bugzilla report. Following the policy for such packages [2], your package will be orphaned if this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29). A week before the mass branching of Fedora 35 according to the schedule [3], any packages not successfully rebuilt at least on Fedora 33 will be retired regardless of the status of this bug. [1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/ [2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/ [3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html Dear Maintainer, your package has an open Fails To Build From Source bug for Fedora 34. Action is required from you. If you can fix your package to build, perform a build in koji, and either create an update in bodhi, or close this bug without creating an update, if updating is not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. If you have already fixed this issue, please close this Bugzilla report. Following the policy for such packages [2], your package will be orphaned if this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29). A week before the mass branching of Fedora 35 according to the schedule [3], any packages not successfully rebuilt at least on Fedora 33 will be retired regardless of the status of this bug. [1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/ [2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/ [3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html This looks like a false positive diagnostic from GCC to me. GCC tries to detect cases where strncpy is used suspiciously, but it's based on some heuristics and while this code triggers those heuristics, it looks correct to me. I suggest something like this to silence the diagnostic in this specific case without silencing it in other cases: diff --git a/util/status.cc b/util/status.cc index ad948f0..9a310c9 100644 --- a/util/status.cc +++ b/util/status.cc @@ -32,8 +32,11 @@ const char* Status::CopyState(const char* state) { assert(ret == 0); return result; #else +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wstringop-overflow=" const size_t cch = std::strlen(state) + 1; // +1 for the null terminator return std::strncpy(new char[cch], state, cch); +#pragma GCC diagnostic pop #endif } (In reply to Jeff Law from comment #8) > This looks like a false positive diagnostic from GCC to me. > > GCC tries to detect cases where strncpy is used suspiciously, but it's based > on some heuristics and while this code triggers those heuristics, it looks > correct to me. > > I suggest something like this to silence the diagnostic in this specific > case without silencing it in other cases: > > > diff --git a/util/status.cc b/util/status.cc > index ad948f0..9a310c9 100644 > --- a/util/status.cc > +++ b/util/status.cc > @@ -32,8 +32,11 @@ const char* Status::CopyState(const char* state) { > assert(ret == 0); > return result; > #else > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Wstringop-overflow=" > const size_t cch = std::strlen(state) + 1; // +1 for the null terminator > return std::strncpy(new char[cch], state, cch); > +#pragma GCC diagnostic pop > #endif > } Thanks, I will test this patch Upgraded to latest version and applied your patch https://koji.fedoraproject.org/koji/taskinfo?taskID=63053663 FEDORA-2021-838f1448ab has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-838f1448ab FEDORA-2021-838f1448ab has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-838f1448ab` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-838f1448ab See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-838f1448ab has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. |