Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 192475
Summary: | Review Request: perl-PadWalker - Play with other peoples' lexical variables | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | iarnell, paul, rc040203 |
Target Milestone: | --- | Flags: | j:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-05-22 21:37:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Jose Pedro Oliveira
2006-05-19 21:24:35 UTC
* package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: 05d684ce2f17ef4f058ec2e912b5f95c PadWalker-1.0.tar.gz 05d684ce2f17ef4f058ec2e912b5f95c PadWalker-1.0.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: PadWalker.so()(64bit) perl(PadWalker) = 1.0 perl-PadWalker = 1.0-1.fc6 - libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) perl >= 0:5.008 perl(:MODULE_COMPAT_5.8.8) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 * shared libraries are present, but internal to Perl so no need to call ldconfig. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=9, Tests=65, 0 wallclock secs ( 0.11 cusr + 0.07 csys = 0.18 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED Thanks for the review. Impoted and built for FC-5 and devel. Package Change Request ====================== Package Name: perl-PadWalker New Branches: EL-6 Owners: iarnell InitialCC: perl-sig rmyers steve Current EL-5 maintainer hasn't responded to EL-6 branch request in bug #612583 CVS done (by process-cvs-requests.py). I'd like to see an EPEL-4 branch for this too; I'm happy to maintain it if none of the existing branch maintainers want to do so. ... and I'd like to see PadWalker upgraded to 1.92 for f13 and f14 ;) Package Change Request ====================== Package Name: perl-PadWalker New Branches: EL-4 Owners: pghmcfc InitialCC: perl-sig rmyers steve iarnell No response to EPEL-4 branch request so I'll maintain it myself; existing maintainers on InitialCC list and they're welcome as co-maintainers of course. Git done (by process-git-requests). perl-PadWalker-1.2-1.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-PadWalker-1.2-1.el4 perl-PadWalker-1.2-1.el4 has been pushed to the Fedora EPEL 4 stable repository. |