Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 192568

Summary:	Review Request: perl-File-Type
Product:	[Fedora] Fedora	Reporter:	Steven Pritchard <steve>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-05-23 21:50:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 192577

Description Steven Pritchard 2006-05-20 20:41:26 UTC

Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-File-Type/perl-File-Type.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-File-Type-0.22-1.src.rpm
Description:
File::Type uses magic numbers (typically at the start of a file) to
determine the MIME type of that file.

Comment 1 Jason Tibbitts 2006-05-21 16:59:15 UTC

A couple of questions:

Any idea why Module::Build shows up in the final requires list and if it really
needs to be there?
What on Earth is the NINJA file for?

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible. Text not included upstream.
* source files match upstream:
   4be3b0b7000b325c60351fcc8a04815d  File-Type-0.22.tar.gz
   4be3b0b7000b325c60351fcc8a04815d  File-Type-0.22.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
? final provides and requires are sane:
   perl(File::Type) = 0.22
   perl(File::Type::Builder) = 0.11
   perl-File-Type = 0.22-1.fc6
  -
   perl(:MODULE_COMPAT_5.8.8)
   perl(IO::File)
   perl(strict)
   perl(warnings)
   rpmlib(CompressedFileNames) <= 3.0.4-1
   rpmlib(PayloadFilesHavePrefix) <= 4.0-1
   rpmlib(VersionedDependencies) <= 3.0.3-1
   perl(Module::Build)
   rpmlib(CompressedFileNames) <= 3.0.4-1
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=3, Tests=58,  0 wallclock secs ( 0.13 cusr +  0.06 csys =  0.19 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Comment 2 Steven Pritchard 2006-05-22 21:23:39 UTC

(In reply to comment #1)
> Any idea why Module::Build shows up in the final requires list and if it really
> needs to be there?

No clue.  I'm not seeing that.

$ rpm -qp --requires perl-File-Type-0.22-2.noarch.rpm
perl(:MODULE_COMPAT_5.8.8)  
perl(IO::File)  
perl(strict)  
perl(warnings)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
$ rpm -qp --provides perl-File-Type-0.22-2.noarch.rpm 
perl(File::Type) = 0.22
perl(File::Type::Builder) = 0.11
perl-File-Type = 0.22-2

Are you sure you aren't picking up BuildRequires?

> What on Earth is the NINJA file for?

Something that wasn't excluded, but should have been.  Fixed in -2.

http://ftp.kspei.com/pub/steve/rpms/perl-File-Type-0.22-2.src.rpm

Comment 3 Jason Tibbitts 2006-05-23 14:01:17 UTC

For some reason I didn't see the bugzilla announcement about your comment. 
Sorry for not responding eariler.

Thanks for excising the ninjas.

I think the reasoun Module::Build showed up in the dependencies was because I
somehow pulled in the requirements of the src.rpm as well; my fault.  Everything
looks good now.

APPROVED

Comment 4 Steven Pritchard 2006-05-23 21:50:37 UTC

Imported into CVS, branches created, and builds requested.