Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 192578
Summary: | Review Request: metamonitor - A Simple program that watches log files and popup its changes | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hugo Cisneiros <hugo> |
Component: | Package Review | Assignee: | Michael J Knox <michael> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-22 21:23:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Hugo Cisneiros
2006-05-20 22:24:23 UTC
Not a Review but some hints to improve Packaging 1) Got error when ran rpmlint on SRPM E: metamonitor description-line-too-long can specify the file to watch and a regular expression for parsing the log line, Wrap the %description at 80 columns 2) A lot of compilation warnings Thanks for your comment. Updated package: Spec URL: http://www.devin.com.br/eitch/rpm/fedora/metamonitor.spec SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/metamonitor-0.4.5-2.src.rpm Changes: - Fixed description field size - Applied patch (0) to modify a symlink to be relative Hey.. I will review this submission... ---------------------------------------- Review for release 2: * RPM name is OK * Source metamonitor-0.4.5.tar.bz2 is the same as upstream * Builds fine in mock * File list looks OK Needs work: * rpmlint: need to fix rpmlint warnings Minor: * Duplicate BuildRequires: arts-devel (by kdelibs-devel), qt-devel (by kdelibs-devel) Notes: rpmlint of metamonitor: W: metamonitor dangling-relative-symlink /usr/share/doc/HTML/en/metamonitor/common ../../en/common Package looks good, fixup the above and I will give it the green light. Hi Michael, Searching about the dangling link says that it could (and should) be ignored, it's not a problem, even if rpmlint warns against it. Many KDE apps have this warning with symlinks on their help files, including the base ones. But I removed the BR as suggested. Thanks! OK, none of those are blockers, so cosider this APPROVED. Please remember to close this review once the package has been imported into CVS and built. Imported and built! Closing. Thanks. |