Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1927439

Summary:	flatpak: glib2 vs extern "C"
Product:	[Fedora] Fedora	Reporter:	Rex Dieter <rdieter>
Component:	flatpak	Assignee:	Kalev Lember <klember>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	34	CC:	amigadave, awilliam, klember, robatino
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	flatpak-1.10.1-3.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-12 20:07:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1829022, 1829023

Description Rex Dieter 2021-02-10 18:00:53 UTC

Related to recent glib2 change, see also bug #1926239

plasma-discover is a C++ application that tries to 
#include <flatpak.h>

but caught in a catch-22 , where
extern "C" {
#include <flatpak.h>
}

now yields compiler errors, and removing the extern yields linker errors like:
/usr/bin/ld: <artificial>:(.text+0x2cc4): undefined reference to `flatpak_ref_get_type()'

I suspect flatpak.h (and friends) may need adjustments to use G_BEGIN_DECLS (just a guess)

Comment 1 Fedora Blocker Bugs Application 2021-02-11 17:18:20 UTC

Proposed as a Blocker and Freeze Exception for 34-beta by Fedora user rdieter using the blocker tracking app because:

 This causes several important plasma components (plasma-discover in particular) to FTBFS.

Comment 2 Adam Williamson 2021-02-11 18:25:55 UTC

FTBFS isn't *necessarily* release blocking unless we actually need to build that thing to fix a blocker/FE bug.

Comment 3 Rex Dieter 2021-02-11 19:37:42 UTC

discover got a good number of recent fixes we'd would like to be testable in the beta (offline update testing could be affected).

Comment 4 Rex Dieter 2021-02-11 19:46:21 UTC

ok, maybe f34-beta FE only, can defer to a F34 GA blocker (we can't ship GA as-is)

Comment 5 Adam Williamson 2021-02-12 00:07:36 UTC

OK. Beta freeze is not till Feb 23, I'll note. If this isn't fixed by then, what I'd say is propose an FE for *the things you would like to change*, and if that gets accepted as an FE then fixing the FTBFS would also clearly be in scope.

Comment 6 Kalev Lember 2021-02-12 15:03:34 UTC

Upstream PR: https://github.com/flatpak/flatpak/pull/4119

I'll go and do downstream builds with this in a bit.

Comment 7 Kalev Lember 2021-02-12 20:07:09 UTC

Should be fixed in flatpak-1.10.1-3.fc34, can you give it a try, please?

Comment 8 Rex Dieter 2021-02-13 21:44:29 UTC

Confirmed good, thank you.

Comment 9 Kalev Lember 2021-02-15 11:48:40 UTC

Great! Thanks for verifying.