Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at

Bug 193210

Summary: Review Request: htmldoc - Convert HTML source files into HTML, PostScript, or PDF
Product: [Fedora] Fedora Reporter: Adam Goode <adam>
Component: Package ReviewAssignee: Aurelien Bompard <gauret>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideFlags: kevin: fedora-cvs+
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-06-05 01:16:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 163779    

Description Adam Goode 2006-05-26 03:56:45 UTC
Spec URL:
Description: HTMLDOC converts HTML source files into indexed HTML, PostScript, or Portable Document Format (PDF) files that can be viewed online or printed.

Comment 1 Adam Goode 2006-05-26 03:58:57 UTC
Sorry, forgot to mention that this is my first package, and I am looking for a

Comment 2 Aurelien Bompard 2006-05-27 14:04:37 UTC
* No downloadable source. Please give the full URL in the Source tag, which
should be
(ok, that one was kind of hard to find...)

Comment 3 Adam Goode 2006-05-27 15:20:01 UTC
Thank you for your comment.

I have created a new package here:

I used %{name} and %{version} in the Source tag. Is that ok, or should I have
put the URL in directly?

Comment 4 Aurelien Bompard 2006-05-28 08:01:09 UTC
Using %{name} and %{version} in the Source tag is up to you. Some packagers
prefer using it, to avoid changing it at every new release, and some packagers
prefer the expanded form, to be able to quickly copy'n'paste into wget. Do what
you prefer.

You have a desktop file already available in the desktop subfolder, please use
it. However, you'll have to add --remove-category=X-Red-Hat-Base to
desktop-file-install, since we don't use it anymore.

The menu entry lacks an icon, please copy the png files in desktop to the proper
place in /usr/share/icons/hicolor/*/apps. (don't forget you'll have to add some
bits to the scriptlets, see,
"GTK+ icon cache")

Comment 5 Adam Goode 2006-05-29 04:52:01 UTC

I've put a new version:

This installs icons, desktop file, and MIME type. (Lots of scriptlets!)
Hope I've got the MIME stuff all right.

Comment 6 Aurelien Bompard 2006-05-29 21:25:03 UTC
Almost there !

* Missing dependancy on update-desktop-database for %post and %postun (package

* Since you're rebuilding, the last 3 lines in the desktop-file-install call are
not properly lined-up (tabs instead of spaces)

Comment 7 Adam Goode 2006-05-30 02:46:59 UTC
Ok, I've fixed the desktop-file-install line-up problem.

I can add the dependencies for %post and %postun, but is
that still a problem? It looks like desktop-file-utils
fixed bug #180898 in 0.10-5 and 0.10-6.

Do I need to add the dependencies for FC4?

Comment 8 Aurelien Bompard 2006-05-30 07:54:12 UTC
Ah, that's true, I didn't know. In the bug, Ray said the fix will be backported
to FC4, so I think you can leave out the Requires entirely.

I found a small bug: if you start the graphical frontend, and click on the
"help" button, you have an error, it can't find the doc. The path is hardcoded
in the configure script, line 5916.
Since the new path depends on the version number, you have two options:
 - make a patch to change this line, and update it with each new version
 - change the line with a sed call in %prep, where maros such as %{version} are

I would choose the 2nd option, because it is less likely to cause errors in the
future (I know *I* would forget to update the patch at least once). But make
sure the regexp is sufficiently specific, this is a large file.

Comment 9 Adam Goode 2006-06-01 03:34:37 UTC
All right, I've added this to %prep:

sed -i 's/\(\$prefix\/share\/doc\/htmldoc\)/\1-%{version}/g' configure

And I also added doc/help.html to %doc.

New SRPM is uploaded, everything seems to work !

Comment 10 Aurelien Bompard 2006-06-01 11:36:39 UTC
Review for release 4:
* RPM name is OK
* Source htmldoc-1.8.26-source.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* Works fine


Comment 11 Adam Goode 2009-02-11 18:23:22 UTC
Package Change Request
Package Name: htmldoc
New Branches: EL-4 EL-5
Owners: agoode pertusus

Comment 12 Kevin Fenzi 2009-02-13 07:04:27 UTC
cvs done.