Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1933794

Summary:	Review Request: secvarctl - A secure variable management tool for POWER's Secure Boot
Product:	[Fedora] Fedora	Reporter:	Nick Child <nnac123>
Component:	Package Review	Assignee:	Dan Horák <dan>
Status:	ASSIGNED ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bugproxy, dan, package-review
Target Milestone:	---	Flags:	dan: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1071880

Description Nick Child 2021-03-01 17:57:40 UTC

Spec URL: https://github.com/open-power/secvarctl/releases/download/v0.1/secvarctl.spec
SRPM URL: https://github.com/open-power/secvarctl/releases/download/v0.1/secvarctl-0.1-1.fc33.src.rpm
Description: secvarctl is a collection of sub-commands for reading, writing and updating secure variables for POWER's Secure Boot.
The sub-commands are:
	-read , prints info on secure variables
	-write , updates secure variable with new signed authenticated file
	-validate , validates format of given file
	-verify , determines if new variable updates are correctly signed/formatted
	-generate , create relevant files for secure variable management
Fedora Account System Username: nnac123

Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=62891320

Comment 1 Dan Horák 2021-03-10 12:37:54 UTC

formal review is here, see the notes explaining OK* and BAD statuses below:

OK	source files match upstream:
	    3ca081c124e9d0ffb6bad4c249adb228b4b5cb56  v0.1.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	license field matches the actual license.
OK	license is open source-compatible (ASL 2.0). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	package builds in mock (Rawhide/ppc64le).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

The package is APPROVED.

Comment 2 Tomas Hrcka 2021-03-11 22:37:32 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/secvarctl