Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1941562

Summary: weasyprint fails to build on rawhide, test failures + segfault
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: weasyprintAssignee: Felix Schwarz <fschwarz>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fschwarz, mhroncok, spacewar, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-14 10:37:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1890881, 1927309    
Attachments:
Description Flags
buil.log with segfaulting tests skipped none

Description Miro Hrončok 2021-03-22 11:18:34 UTC 
weasyprint fails to build with Python 3.10.0a6 and Python 3.9.2 on rawhide.

+ pytest-3 -k 'not test_text and not test_float and not test_table_vertical_align'
============================= test session starts ==============================
platform linux -- Python 3.10.0a6, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /builddir/build/BUILD/WeasyPrint-52.4, configfile: setup.cfg
plugins: cov-2.11.1
collected 1320 items / 122 deselected / 1198 selected
weasyprint/tests/test_acid2.py .                                         [  0%]
weasyprint/tests/test_api.py ...................                         [  1%]
weasyprint/tests/test_boxes.py ......................................... [  5%]
................                                                         [  6%]
weasyprint/tests/test_counters.py .............................          [  8%]
weasyprint/tests/test_css.py ........................................... [ 12%]
.........................                                                [ 14%]
weasyprint/tests/test_css_descriptors.py ...............                 [ 15%]
weasyprint/tests/test_css_validation.py ................................ [ 18%]
........................................................................ [ 24%]
....................................................                     [ 28%]
weasyprint/tests/test_fonts.py FFFFF                                     [ 29%]
weasyprint/tests/test_pdf.py ..................................          [ 32%]
weasyprint/tests/test_presentational_hints.py .........                  [ 32%]
weasyprint/tests/test_stacking.py ........                               [ 33%]
weasyprint/tests/test_target.py .....                                    [ 33%]
weasyprint/tests/test_tools.py ..                                        [ 34%]
weasyprint/tests/test_unicode.py .                                       [ 34%]
weasyprint/tests/test_variables.py ..................................... [ 37%]
........................................................................ [ 43%]
...................................................                      [ 47%]
weasyprint/tests/test_draw/test_background.py .......................... [ 49%]
..................                                                       [ 51%]
weasyprint/tests/test_draw/test_before_after.py ...                      [ 51%]
weasyprint/tests/test_draw/test_box.py .....                             [ 51%]
weasyprint/tests/test_draw/test_column.py ..                             [ 52%]
weasyprint/tests/test_draw/test_current_color.py ....                    [ 52%]
weasyprint/tests/test_draw/test_gradient.py ...........                  [ 53%]
weasyprint/tests/test_draw/test_image.py ...................             [ 54%]
weasyprint/tests/test_draw/test_list.py ...                              [ 55%]
weasyprint/tests/test_draw/test_opacity.py ...                           [ 55%]
weasyprint/tests/test_draw/test_overflow.py ........                     [ 56%]
weasyprint/tests/test_draw/test_table.py .....................x.         [ 57%]
weasyprint/tests/test_draw/test_transform.py .............               [ 59%]
weasyprint/tests/test_draw/test_visibility.py ...                        [ 59%]
weasyprint/tests/test_layout/test_block.py ............................. [ 61%]
................................x....                                    [ 64%]
weasyprint/tests/test_layout/test_column.py ...........FF.........       [ 66%]
weasyprint/tests/test_layout/test_flex.py .............x............     [ 68%]
weasyprint/tests/test_layout/test_image.py ....................          [ 70%]
weasyprint/tests/test_layout/test_inline.py .x....FFFFFFFxFFFF.......... [ 72%]
..F...............FF                                                     [ 74%]
weasyprint/tests/test_layout/test_inline_block.py ..                     [ 74%]
weasyprint/tests/test_layout/test_list.py .......xF                      [ 75%]
weasyprint/tests/test_layout/test_page.py .............................. [ 77%]
..x......................F.................................              [ 82%]
weasyprint/tests/test_layout/test_position.py .............              [ 83%]
weasyprint/tests/test_layout/test_shrink_to_fit.py ..................... [ 85%]
............................................................/var/tmp/rpm-tmp.Pbqxoo: line 38:   672 Trace/breakpoint trap   (core dumped) pytest-3 -k "not test_text and not test_float and not test_table_vertical_align"
error: Bad exit status from /var/tmp/rpm-tmp.Pbqxoo (%check)

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/02086151-weasyprint/

For all our attempts to build weasyprint with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/weasyprint/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.
Comment 1 Miro Hrončok 2021-03-22 11:27:43 UTC 
Created attachment 1765215 [details]
buil.log with segfaulting tests skipped

I've added --ignore weasyprint/tests/test_layout/test_shrink_to_fit.py to be able to at least see the regular failures.

It seems that many of the failures have to do with "width". E.g.:

>       assert kern.width == 1.5 * 16
E       assert 18.0 == (1.5 * 16)
E        +  where 18.0 = <InlineBox span>.width

But there are other failures as well:

>       column1, column2, section1, section2, column3, column4 = div.children
E       ValueError: not enough values to unpack (expected 6, got 4)

Full log attached.
Comment 2 Felix Schwarz 2021-03-23 23:09:48 UTC 
There was an incompatibility with pango 1.48.3. I cherry-picked an upstream patch to fix that.

rawhide build succeeds now: https://koji.fedoraproject.org/koji/taskinfo?taskID=64462748
Comment 3 Miro Hrončok 2021-06-04 20:15:39 UTC 
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/
Comment 4 Miro Hrončok 2021-06-07 23:00:01 UTC 
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.
Comment 5 Miro Hrončok 2021-06-14 10:37:22 UTC 
This package was successfully rebuilt with Python 3.10.

If you need this bugzilla open for tracking purposes, sorry for the automatic closing: feel free to reopen it.