Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 194470
Summary: | Review Request: php-magickwand | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-15 05:13:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 195864 | ||
Bug Blocks: | 163779 |
Description
Robert Scheck
2006-06-08 12:48:25 UTC
Restoring work lost due to the BZ crash. This package has had a full review, if I remember correctly the only MUST fix item were 3 rpmlint messages. One of the was related to rpath problems and turned out to only show on 64 bit archs. The fix for the rpath problem is to add: export PHP_RPATH=no before: %configure under: %setup Robert also posted a new version, available from: http://labs.linuxnetz.de/bugzilla/ Which I've just fully re-reviewed, all is good: Approved! Leaving the blockerbugs as is for now untill we've got 2 other packages sorted out and I'm going to sponsor you having a package blocking FE-ACCEPT without it being imported is going to make some scripts which do automated sanity checks on the whole review process unhappy. Problem mentioned in bug #194479 is now resolved for php-magickwand, too. The package failed building in FC5 but was successful in devel, see: - http://buildsys.fedoraproject.org/logs/fedora-5-extras/11170-php-magickwand-0. 1.8-2.fc5/i386/build.log - http://buildsys.fedoraproject.org/logs/fedora-development-extras/11169-php- magickwand-0.1.8-2.fc6/i386/build.log When installing ImageMagick-6.2.5.4-4.2.1.fc5.3, I'm able to reproduce the problem, when using my own local rebuild of same version, I'm not. But I've to say, that my local system isn't more devel rather FC5... Hmm, the FC-5 build.log isn't being helpfull. Please do a FC-5 mock build (which should give the same error) and then attach the config.log from the mock builddir. Ha, found the shit: ImageMagick 6.2.5.4 got every linking information hardcoded into Wand-config and so is always linking against freetype-devel, but freetype- devel is unfortunately no build requirement of ImageMagick-devel. I opened bug #195864, because adding the requirement to php-magickwand is IMHO the wrong way as every application depending on ImageMagick(-devel) will fail because of this... I'll rebuild php-magickwand for FC-5 branch, when bug #195864 is resolved and pushed to Updates directory. You could also concider adding a freetype-devel BR to the FC-5 spec file as a workaround for now and remove it later when this issue gets really fixed. (When removing don't request a build unless there are other _real_ changes). Handle this however you like, Im just trying to give you some options. Closing since this has been build for Development, currently its showing up in: http://fedoraproject.org/wiki/Extras/PackageStatus As needs cleanup, so I'm cleaning up :) BTW, did you verify this package matches the recent "released" php packaging guidelines? As per current status of http://fedoraproject.org/wiki/Packaging/PHP, PHP RPM packages like this aren't handled, yet. And of my understanding, any package not listed at http://pecl.php.net/, isn't a PHP PECL package. Package Change Request ====================== Package Name: php-magickwand New Branches: epel7 Owners: robert Git done (by process-git-requests). |