Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1948144

Summary:	Review Request: rust-sha1collisiondetection - SHA-1 hash function with collision detection and mitigation
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-04-13 13:48:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1948154

Description Fabio Valentini 2021-04-10 10:36:46 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-sha1collisiondetection.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-sha1collisiondetection-0.2.3-1.fc33.src.rpm

Description:
SHA-1 hash function with collision detection and mitigation.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-04-10 10:36:50 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=65641494

Comment 2 Robert-André Mauchin 🐧 2021-04-11 18:12:27 UTC

 - Shouldn't you add the license file here too:

%if ! %{__cargo_skip_build}
%package     -n %{crate}
Summary:        %{summary}
# ASL 2.0 or MIT
# MIT
# MIT or ASL 2.0
License:        MIT

%description -n %{crate} %{_description}

%files       -n %{crate}
%license LICENSE.txt
%doc README.md
%{_bindir}/sha1cdsum
%endif

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please consider the aforementioned issue.

Comment 3 Fabio Valentini 2021-04-12 09:36:40 UTC

>  - Shouldn't you add the license file here too:

Yes, absolutely. I missed that. I've fixed it before the import.

https://pagure.io/releng/fedora-scm-requests/issue/33465
https://pagure.io/releng/fedora-scm-requests/issue/33466

Comment 4 Gwyn Ciesla 2021-04-12 14:31:58 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sha1collisiondetection

Comment 5 Fedora Update System 2021-04-13 13:48:06 UTC

FEDORA-2021-c1fecf829f has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.