Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1949430
| Summary: | python-wsproto fails to build with Python 3.10: AssertionError: assert 'H11Handshake..., state=OPEN)' == 'H11Handshake...onState.OPEN)' | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomáš Hrnčiar <thrnciar> |
| Component: | python-wsproto | Assignee: | Carl George 🤠 <carl> |
| Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | carl, code, mhroncok, python-sig, thrnciar |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-07-12 12:44:39 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1890881, 1927309, 1927313, 1969166 | ||
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.
The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.
You can either build the package in the side tag, with:
$ fedpkg build --target=f35-python
Or you can the build and we will eventually build it for you.
Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.
Thanks.
See also https://fedoraproject.org/wiki/Changes/Python3.10
If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build. *** Bug 1969171 has been marked as a duplicate of this bug. *** Reported upstream: https://github.com/python-hyper/wsproto/issues/159 Hello, This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs). If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem. It’s only the one test that fails, and there shouldn’t be any impact on users who aren’t depending on the exact string value of “repr(<something from wsproto>)”. Would you consider skipping the test—
> %check
> # https://github.com/python-hyper/wsproto/issues/159
> %pytest --verbose -k 'not test_successful_handshake'
—as a workaround until upstream decides what to do? Or do you want to keep waiting for upstream?
The package no longer fails to build with Python 3.10.0b4. I will take care of the rebuild. Please note that the standard library enum implementation was reverted upstream to the Python 3.9 version; if the failure was enum related (such as tests expecting a specific Enum.__repr__ value) it will likely happen again with Python 3.11. https://mail.python.org/archives/list/python-dev@python.org/message/LSTMFAPSPD3BGZ4D6HQFODXZVB3PLYKF/ Hello, Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok). All subpackages of a package against which this bug was filled are now installable or removed from Fedora 35. Thanks for taking care of it! |
python-wsproto fails to build with Python 3.10.0a7. =================================== FAILURES =================================== __________________________ test_successful_handshake ___________________________ def test_successful_handshake() -> None: client = H11Handshake(CLIENT) server = H11Handshake(SERVER) server.receive_data(client.send(Request(host="localhost", target="/"))) assert isinstance(next(server.events()), Request) client.receive_data(server.send(AcceptConnection())) assert isinstance(next(client.events()), AcceptConnection) assert client.state is ConnectionState.OPEN assert server.state is ConnectionState.OPEN > assert repr(client) == "H11Handshake(client=True, state=ConnectionState.OPEN)" E AssertionError: assert 'H11Handshake..., state=OPEN)' == 'H11Handshake...onState.OPEN)' E - H11Handshake(client=True, state=ConnectionState.OPEN) E ? ---------------- E + H11Handshake(client=True, state=OPEN) test/test_handshake.py:22: AssertionError =========================== short test summary info ============================ FAILED test/test_handshake.py::test_successful_handshake - AssertionError: as... ======================== 1 failed, 225 passed in 0.78s ========================= There were some changes in repr() in latest alpha of Python 3.10. https://docs.python.org/3.10/whatsnew/changelog.html#python-3-10-0-alpha-7 bpo-40066: Enum: adjust repr() to show only enum and member name (not value, nor angle brackets) and str() to show only member name. Update and improve documentation to match. bpo-40066: Enum’s repr() and str() have changed: repr() is now EnumClass.MemberName and str() is MemberName. Additionally, stdlib Enum’s whose contents are available as module attributes, such as RegexFlag.IGNORECASE, have their repr() as module.name, e.g. re.IGNORECASE. https://bugs.python.org/issue40066 For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/02127323-python-wsproto/ For all our attempts to build python-wsproto with Python 3.10, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-wsproto/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/ Let us know here if you have any questions. Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.