Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 195846

Summary:	Review Request: pengupop - Networked Game in the vein of Move/Puzzle Bobble
Product:	[Fedora] Fedora	Reporter:	Hugo Cisneiros <hugo>
Component:	Package Review	Assignee:	Wart <wart>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	gwync
Target Milestone:	---	Flags:	petersen: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-06-19 13:49:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Hugo Cisneiros 2006-06-18 18:46:24 UTC

Spec URL: http://www.devin.com.br/eitch/fextras/SPECS/pengupop.spec
SRPM URL: http://www.devin.com.br/eitch/fextras/SRPMS/pengupop-2.0.2-1.src.rpm
Description:

Finally a networked multiplayer game in the vein of the puzzle classic Bust a
Move/Puzzle Bobble. Beat your friends in this addictive game, or play against
a random opponent! The purpose of this game is to shoot colored orbs into your
playfield, so they form groups of three or more. You win if you manage to
remove all orbs. You lose if any orb attaches below the white line.

You can make the job harder for your opponent by making orbs fall down as a
side-effect of you forming a group. For example, on the screenshot shown on
this page, the player on the right playfield can fire a black orb onto the
three black orbs in the middle of his field, and cause the seven orbs below to
reapper on his opponent's playfield.

Comment 1 Wart 2006-06-18 23:45:21 UTC

MUST
====
* rpmlint output clean
* Package and spec named appropriately
* Source matches upstream:
  5c213ecb3cf1bd714dbae771f97ee19a  pengupop-2.0.2.tar.gz
* GPL license ok, license file included
* Spec file legible and in Am. English
* No excessive BR:
* No locales
* No shared libs
* No need for a -devel subpackage (no headers, libs, or *.pc)
* Not relocatable
* Permissions look ok
* $RPM_BUILD_ROOT cleaned where needed
* Contains code, not content
* No need for -doc subpackage
* %doc does not affect runtine
* .desktop file installed correctly
* Does not own directories that it shouldn't
* Builds and packages on mock for:
  FC4-i386, FC4-x86_64, FC5-i386, FC5-x86_64

MUSTFIX
=======
* Missing BR: desktop-file-utils
* The %description refers to screenshots which aren't visible in the spec.
  Best just to remove the second paragraph from the %description.
* In the desktop-file-install, use $RPM_BUILD_ROOT instead of ${RPM_BUILD_ROOT}
  for consistency.

Comment 2 Hugo Cisneiros 2006-06-19 00:45:08 UTC

Package Updated:

Spec URL: http://www.devin.com.br/eitch/fextras/SPECS/pengupop.spec
SRPM URL: http://www.devin.com.br/eitch/fextras/SRPMS/pengupop-2.0.2-2.src.rpm

Changes:

- Added desktop-file-utils BR
- Removed description inconsistency

Comment 3 Wart 2006-06-19 01:03:34 UTC

All MUSTFIX items fixed.

APPROVED

Comment 4 Rudolf Kastl 2006-06-19 10:59:21 UTC

sweet :)

Comment 5 Hugo Cisneiros 2006-06-19 13:49:55 UTC

Imported and built! Thanks

Comment 6 Gwyn Ciesla 2007-02-28 13:49:53 UTC

Change owner to limb (orphaned)

Comment 7 Gwyn Ciesla 2007-03-01 19:41:05 UTC

Add lxtnow as co-maintainer.