Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 196091

Summary:	Review Request: cksfv - Utility to manipulate SFV files
Product:	[Fedora] Fedora	Reporter:	Christopher Stone <chris.stone>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	kevin: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-06-21 06:42:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Christopher Stone 2006-06-20 22:09:29 UTC

Spec URL: http://tkmame.retrogames.com/fedora-extras/cksfv.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/cksfv-1.3.9-1.src.rpm

Description:
cksfv is a utility that can create and use SFV files. SFV (Simple File
Verification) files are used to verify file integrity using CRC32
checksums.

NOTE:  This is an orphaned package, but I created a new spec file from scratch, so I'm requesting a review.

Comment 1 John Mahowald 2006-06-21 00:41:50 UTC

- rpmlint checks return:
E: cksfv configure-without-libdir-spec

Not for this configure, as noted in the spec.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED

Comment 2 Christopher Stone 2008-05-25 21:50:31 UTC

Package Change Request
======================
Package Name: cksfv
New Branches: EL-5

Comment 3 Kevin Fenzi 2008-05-26 04:17:08 UTC

cvs done.