Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1965963

Summary: watchman: FTBFS in Fedora rawhide
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: watchmanAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 35CC: davide, droidbittin, filbranden, lruzicka, mhroncok, michel, mtasaka
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://koschei.fedoraproject.org/package/watchman
Whiteboard: AcceptedFreezeException
Fixed In Version: watchman-2021.05.10.00-5.fc35 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-16 23:55:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1984192    
Bug Blocks: 1890881, 1891954, 1927309, 1927313, 1992484, 1992487    

Description Tomáš Hrnčiar 2021-05-31 09:01:08 UTC
Description of problem:
Package watchman fails to build from source in Fedora rawhide.

Version-Release number of selected component (if applicable):
2021.04.12.00-1.fc35

Steps to Reproduce:
koji build --scratch f35 watchman-2021.04.12.00-1.fc35.src.rpm

Additional info:
This package is tracked by Koschei. See:
https://koschei.fedoraproject.org/package/watchman

Comment 1 Miro Hrončok 2021-06-04 20:15:18 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 2 Miro Hrončok 2021-06-07 22:59:46 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 3 Miro Hrončok 2021-06-08 11:50:09 UTC
*** Bug 1969200 has been marked as a duplicate of this bug. ***

Comment 4 Miro Hrončok 2021-06-15 20:28:39 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 5 Miro Hrončok 2021-07-07 11:38:38 UTC
Hello,

This is the second reminder (step 4 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 6 Fedora Release Engineering 2021-07-11 04:22:55 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-07-26).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 7 Michel Lind 2021-07-13 18:46:33 UTC
This was previously non actionable due to folly and fbthrift failing to build; those have cleared, but watchman itself is not buildable at the moment:
- the latest successful build (2021.04.26.00) can no longer be rebuilt due to folly changes
- newer releases introduce Rust source code, we'll need to rework the packaging

Comment 8 Ben Cotton 2021-08-10 13:04:58 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 9 Miro Hrončok 2021-08-30 22:36:08 UTC
(In reply to Michel Alexandre Salim from comment #7)
> This was previously non actionable due to folly and fbthrift failing to
> build; those have cleared, but watchman itself is not buildable at the
> moment:
> - the latest successful build (2021.04.26.00) can no longer be rebuilt due
> to folly changes
> - newer releases introduce Rust source code, we'll need to rework the
> packaging

Michel, do you have a status update about the reworked packaging?

Comment 10 Davide Cavalca 2021-08-31 17:42:15 UTC
I've managed to get the rust components packaged separately at https://src.fedoraproject.org/rpms/rust-watchman_client and https://src.fedoraproject.org/rpms/rust-serde_bser however the watchman build system still needs to be reworked to not attempt to fetch stuff from cargo.

Comment 11 Mamoru TASAKA 2021-09-09 13:03:01 UTC
Note that fixing compilation itself for current watchman-2021.05.10.00 is possible with small modification:

F-36 https://koji.fedoraproject.org/koji/taskinfo?taskID=75406604
F-35 https://koji.fedoraproject.org/koji/taskinfo?taskID=75406606

.... although with gtest 1.11.0, watchman testsuite does not build and I cannot find out how to fix,
so for rawhide (F36) I've completely disabled building test suite 

(but currently %check is  not executed currently, so I hope this is okay)

Comment 12 Miro Hrončok 2021-09-13 09:22:40 UTC
Mamoru, let's push those changes out to unblock this?

Comment 13 Mamoru TASAKA 2021-09-13 11:35:25 UTC
(In reply to Miro Hrončok from comment #12)
> Mamoru, let's push those changes out to unblock this?

Okay. Wait a few hours...

Comment 14 Mamoru TASAKA 2021-09-13 12:39:13 UTC
F-36 built successfully
https://koji.fedoraproject.org/koji/buildinfo?buildID=1831122

F-35 is also built: will submit bodhi updates request.

Comment 15 Fedora Update System 2021-09-13 12:39:58 UTC
FEDORA-2021-8ae3c2ec95 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8ae3c2ec95

Comment 16 Miro Hrončok 2021-09-13 12:48:38 UTC
Thank you!

Requesting a freeze exception, as python3-pywatchman doe snot install without this fix.

Comment 17 Fedora Update System 2021-09-13 16:15:40 UTC
FEDORA-2021-8ae3c2ec95 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-8ae3c2ec95`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8ae3c2ec95

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Luna Jernberg 2021-09-13 16:21:46 UTC
FE accepted

proposed #agreed 1965963 - The decision to classify this bug as an "AcceptedFreezeException (Beta)" was made as it is a noticeable issue that cannot be fixed with an update.

Comment 19 Davide Cavalca 2021-09-13 18:42:52 UTC
Thanks a lot for fixing this, and apologies for not following up sooner. Your changes lgtm, I'll spend some time later this week and see if I can make progress on the newer version, but in the meantime this should be enough to unblock F35.

Comment 20 Fedora Update System 2021-09-16 23:55:59 UTC
FEDORA-2021-8ae3c2ec95 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.