Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 196620
Summary: | Review Request: perl-Algorithm-Annotate - represent a series of changes in annotate form | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ian Burrell <ianburrell> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | herrold |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-06-29 06:44:07 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 196629 |
Description
Ian Burrell
2006-06-26 01:49:04 UTC
Several mirror issues: # rpmlint perl-Algorithm-Annotate-0.10-1.fc5.noarch.rpm W: perl-Algorithm-Annotate summary-not-capitalized represent a series of changes in annotate form W: perl-Algorithm-Annotate spelling-error-in-description simliar similar W: perl-Algorithm-Annotate invalid-license CHECK(GPL or Artistic) * Empty %doc. * Superfluous requires: Requires: perl(Algorithm::Diff) >= 1.15 Seems as if you missed to manually edit a generated spec file ;) Please fix. I fixed the warnings. There are no doc files included beyond the man page. The META.yml specifies a version for Algorithm::Diff so a versioned dependency is proper. Since only a newer version is available, the version probably doesn't matter. http://znark.com/fedora/perl-Algorithm-Annotate.spec http://znark.com/fedora/perl-Algorithm-Annotate-0.10-3.src.rpm (In reply to comment #2) > The > META.yml specifies a version for Algorithm::Diff so a versioned dependency The actual files contain no versioned dependency. > Since only a newer version is available, the version probably doesn't > matter. Exactly. That's why I consider it superfluous. It's worse than superfluous. You get this in the dependency list: perl(Algorithm::Diff) perl(Algorithm::Diff) >= 1.15 I have no problem with you specifying a specific version, although as far as I can tell the earliest version that was ever in Extras was 1.19 so you shouldn't need to worry. If you really want to, however, you _must_ filter the unversioned dependency generated by RPM. Let me know if you need help doing this. The package does build in mock; rpmlint has this to day: W: perl-Algorithm-Annotate incoherent-version-in-changelog 0.10-2 0.10-3.fc6 You neglected to add a changelog entry for the last version bump. Also, your %doc tag has no files. I understand that there are none to ship, so you should just remove it. So I see three blockers. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 453395489640e28fc772944ef08d396b Algorithm-Annotate-0.10.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. X final requires list has a duplicate entry: perl(Algorithm::Annotate) = 0.10 perl-Algorithm-Annotate = 0.10-3.fc6 = perl(:MODULE_COMPAT_5.8.8) X perl(Algorithm::Diff) X perl(Algorithm::Diff) >= 1.15 perl(strict) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.02 cusr + 0.02 csys = 0.04 CPU) * no scriptlets present. * code, not content. X no documentation, but empty %doc tag. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. Fixed. Spec: http://znark.com/fedora/perl-Algorithm-Annotate.spec SRPMS: http://znark.com/fedora/perl-Algorithm-Annotate-0.10-4.src.rpm Three blockers are fixed: No more versioned Algorithm::Diff dependency. No empty %doc tag. Changelog entries include versions. APPROVED Built for devel. Package Change Request ====================== Package Name: perl-Algorithm-Annotate New Branches: EL-4 EL-5 cvs done. Kevin -- I see this is closed, but CPAN carries this as license 'Unknown' at one point, and Artistic down in the footer to the POD explosion sub-page see: http://search.cpan.org/dist/Algorithm-Annotate/ Is this a problem? -- Russ At the bottom of the POD you see: " Copyright 2003 by Chia-liang Kao <clkao>. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. " This is "GPLv2+ or Artistic" which is valid for software in Fedora. |