Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 196622
| Summary: | Review Request: perl-PerlIO-eol - PerlIO layer for normalizing line endings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ian Burrell <ianburrell> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-06-29 06:44:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 196629 | ||
|
Description
Ian Burrell
2006-06-26 01:57:34 UTC
Minor issue: # rpmlint perl-PerlIO-eol-0.13-2.i386.rpm W: perl-PerlIO-eol incoherent-version-in-changelog 0.13-1 0.13-2 Fixed the warning. Spec: http://znark.com/fedora/perl-PerlIO-eol.spec SRPMS: http://znark.com/fedora/perl-PerlIO-eol-0.13-3.src.rpm Note that BuildRequires: perl is redundant; it is in the default build root. The version requirement is satisfied on all platforms that Extras supports so it's safe to leave it out. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 7e11fb1cc3b2a65678714877ae361823 PerlIO-eol-0.13.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: eol.so()(64bit) perl(PerlIO::eol) = 0.13 perl-PerlIO-eol = 0.13-3.fc6 = perl >= 0:5.007003 perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(XSLoader) * shared libraries are present, internal to Perl. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=1, Tests=23, 0 wallclock secs ( 0.02 cusr + 0.01 csys = 0.03 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED Built for devel. Package Change Request ====================== Package Name: perl-PerlIO-eol New Branches: EL-4 EL-5 cvs done. |