Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 196827 (pear-Image-GraphViz)
Summary: | Review Request: php-pear-Image-GraphViz - PEAR: Interface to AT&T's GraphViz tools | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-08 00:40:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 196837 |
Description
Christopher Stone
2006-06-27 02:53:37 UTC
Shouldn't this package have some kind of dependency on graphviz? Yeah, youre probably right. I added graphviz to the Requires. Cool. Builds OK and rpmlint has only it's usual dangerous-command-in-%post spew which should be ignored. * source files match upstream: 8828e58960e0d93820cb3bdcce85e705 Image_GraphViz-1.2.1.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent (except for erroneous warnings) * final provides and requires are sane: php-pear(Image_GraphViz) = 1.2.1 php-pear-Image-GraphViz = 1.2.1-1.fc6 = /bin/sh /usr/bin/pear graphviz php-pear(PEAR) * %check is not present; no test suite upstream. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (PEAR module installation) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Package Change Request ====================== Package Name: php-pear-Image-GraphViz New Branches: EL-5 cvs done. |